Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #809, es child task functional test #1289

Conversation

zanzaben
Copy link
Contributor

@zanzaben zanzaben commented Apr 9, 2021

Describe the contribution
Fixes #809
adds new functional tests for child cases.

Fixes #1291
Fixed spelling mistake

Expected behavior changes
none

System(s) tested on
Ubuntu 20.04

Additional context
This is just the most simple cases, edge cases are not checked.

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@zanzaben zanzaben force-pushed the fix809_ES_Child_Task_Functional_Test branch from cfc23c2 to 5852067 Compare April 12, 2021 14:20
@zanzaben zanzaben added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 14, 2021
@skliper skliper added CCB:2021-04-14 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 14, 2021
@skliper
Copy link
Contributor

skliper commented Apr 14, 2021

CCB:2021-04-14 - reviewed WIP, good to move forward

@zanzaben zanzaben force-pushed the fix809_ES_Child_Task_Functional_Test branch from 9a1bb66 to fbdf2cf Compare April 16, 2021 17:07
@zanzaben zanzaben changed the title WIP Fix809 es child task functional test Fix809 es child task functional test Apr 16, 2021
@zanzaben zanzaben marked this pull request as ready for review April 16, 2021 17:08
@astrogeco astrogeco changed the title Fix809 es child task functional test Fix #809 es child task functional test Apr 22, 2021
@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Apr 22, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Apr 22, 2021

@zanzaben can you amend the commit message? Need to fix its format.

@astrogeco astrogeco changed the title Fix #809 es child task functional test Fix #809, es child task functional test Apr 22, 2021
@zanzaben zanzaben force-pushed the fix809_ES_Child_Task_Functional_Test branch from fbdf2cf to 4c5b215 Compare April 22, 2021 18:00
@zanzaben zanzaben force-pushed the fix809_ES_Child_Task_Functional_Test branch from 4c5b215 to d785db8 Compare April 22, 2021 18:02
@astrogeco astrogeco changed the base branch from main to integration-candidate April 28, 2021 00:46
@astrogeco astrogeco merged commit 27c49a1 into nasa:integration-candidate Apr 28, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 28, 2021
nasa/cFE#1379, memory pool pointer type
nasa/cFE#1289, ES child task functional test
nasa/cFE#1289, typo in macro name
nasa/cFE#1286, Remove broken BUILDDIR reference
nasa/cFE#1305, remove option for "osal_compatible"
nasa/cFE#1374, CFE_SUCCESS constant type
nasa/cFE#1316, Remove Unused Error Codes
nasa/cFE#1370, better warning about malformed startup line
nasa/cFE#1373, check status of call to `CFE_ES_CDS_CachePreload`
nasa/cFE#1384, update documentation for `CFE_ES_DeleteCDS`
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 29, 2021
Combines:

nasa/cFE#1431
nasa/osal#975
nasa/sample_lib#61

Includes:

nasa/cFE#1379, memory pool pointer type
nasa/cFE#1289, ES child task functional test
nasa/cFE#1289, typo in macro name
nasa/cFE#1286, Remove broken BUILDDIR reference
nasa/cFE#1305, remove option for "osal_compatible"
nasa/cFE#1374, CFE_SUCCESS constant type
nasa/cFE#1316, Remove Unused Error Codes
nasa/cFE#1370, better warning about malformed startup line
nasa/cFE#1373, check status of call to `CFE_ES_CDS_CachePreload`
nasa/cFE#1384, update documentation for `CFE_ES_DeleteCDS`
nasa/cFE#1385, exception logic when app/task is not found
nasa/cFE#1372, error if alignment size not a power of two
nasa/cFE#1368, remove unneeded CFE_ES_SYSLOG_APPEND macro
nasa/cFE#1382, improve documentation for resourceID patterns
nasa/cFE#1371, assert `CFE_RESOURCEID_MAX` is a bitmask

nasa/osal#972, update documentation for read/write
nasa/osal#966, add "handler" feature to utassert stub API
nasa/osal#953, Adds local makefile and bundle/local unit test actions with coverage verification
nasa/osal#971, socket accept using incorrect record
nasa/osal#959, move async console option

nasa/sample_lib#60, replace direct ref to ArgPtr with macro
@zanzaben zanzaben deleted the fix809_ES_Child_Task_Functional_Test branch May 21, 2021 16:15
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typo in test macro name: UtAssert_ResourceID_Undifeined Add cFE ES Child Task API functional tests
3 participants