Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #419 #729 #954, Adds local makefile and bundle/local unit test actions with coverage verification #953

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Apr 9, 2021

Describe the contribution
Fix #419 - Adds local makefile (trivial single build sample, can use different build directories for multiple platform)
Fix #729 - Adds bundle and local unit test run and coverage verification
Fix #954 - Added missing line coverage

Testing performed
Self testing! Also checked distclean and install independently.

Expected behavior changes
Runs the unit tests again, both from the context of the bundle config and local OSAL config. Verifies 100% line coverage.

System(s) tested on

  • Hardware: Local docker container
  • OS: Ubuntu 18.04
  • Versions: cFS Bundle main + these commits

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added enhancement CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) continuous-integration build-system labels Apr 9, 2021
@skliper skliper added this to the 6.0.0 milestone Apr 9, 2021
@skliper skliper changed the title Fix #419 and #729 - Adds local makefile and bundle/local unit test actions with coverage verification Fix #419 #729 #954- Adds local makefile and bundle/local unit test actions with coverage verification Apr 9, 2021
@skliper skliper changed the title Fix #419 #729 #954- Adds local makefile and bundle/local unit test actions with coverage verification Fix #419 #729 #954, Adds local makefile and bundle/local unit test actions with coverage verification Apr 14, 2021
@skliper skliper added CCB:2021-04-14 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 14, 2021
@skliper
Copy link
Contributor Author

skliper commented Apr 14, 2021

CCB:2021-04-14 - APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate April 22, 2021 15:26
@astrogeco astrogeco merged commit 8fad92d into nasa:integration-candidate Apr 28, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 28, 2021
nasa/osal#972, update documentation for read/write
nasa/osal#966, add "handler" feature to utassert stub API
nasa/osal#953, Adds local makefile and bundle/local unit test actions with coverage verification
nasa/osal#971, socket accept using incorrect record
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 29, 2021
Combines:

nasa/cFE#1431
nasa/osal#975
nasa/sample_lib#61

Includes:

nasa/cFE#1379, memory pool pointer type
nasa/cFE#1289, ES child task functional test
nasa/cFE#1289, typo in macro name
nasa/cFE#1286, Remove broken BUILDDIR reference
nasa/cFE#1305, remove option for "osal_compatible"
nasa/cFE#1374, CFE_SUCCESS constant type
nasa/cFE#1316, Remove Unused Error Codes
nasa/cFE#1370, better warning about malformed startup line
nasa/cFE#1373, check status of call to `CFE_ES_CDS_CachePreload`
nasa/cFE#1384, update documentation for `CFE_ES_DeleteCDS`
nasa/cFE#1385, exception logic when app/task is not found
nasa/cFE#1372, error if alignment size not a power of two
nasa/cFE#1368, remove unneeded CFE_ES_SYSLOG_APPEND macro
nasa/cFE#1382, improve documentation for resourceID patterns
nasa/cFE#1371, assert `CFE_RESOURCEID_MAX` is a bitmask

nasa/osal#972, update documentation for read/write
nasa/osal#966, add "handler" feature to utassert stub API
nasa/osal#953, Adds local makefile and bundle/local unit test actions with coverage verification
nasa/osal#971, socket accept using incorrect record
nasa/osal#959, move async console option

nasa/sample_lib#60, replace direct ref to ArgPtr with macro
@skliper skliper deleted the fix729-unit_test_action branch October 22, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants