Fix #468, Adding coverage for cfe_es_task.c #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepepr08
changed the title
pepepr08
changed the title
pepepr08
force-pushed
the
fix468-es-task-ut
branch
from
07a7430
to
7cd7088
Compare
pepepr08
added
the
CCB:Ready
skliper
approved these changes
Jun 30, 2021
pepepr08
changed the title
astrogeco
added
CCB:Approved
|
CCB:2021-06-30 APPROVED |
Test the following cases: - CFE_ES_TaskMain() with a CFE_ES_TaskInit() error - Query tasks command with valid lib ID - Error when sending Build Info event - CFE_ES_GenerateVersionEvents() error when sending mission event - Loop coverage for CFE_ES_FindConfigKeyValue()
pepepr08
force-pushed
the
fix468-es-task-ut
branch
from
7cd7088
to
fcf9b7b
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 30, 2021
**Combines** nasa/cFE#1654 **Includes** nasa/cFE#1444, Change index type to resolve infinite loop warning nasa/cFE#1653, Adding coverage for cfe_es_task.c nasa/cFE#1638, Expand FS Header Functional tests.
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 7, 2021
**Combines** nasa/cFE#1654, cfe v6.8.0-rc1+dev739 nasa/osal#1098, osal v5.1.0-rc1+dev564 **Includes** nasa/cFE#1444, Change index type to resolve infinite loop warning nasa/cFE#1653, Adding coverage for cfe_es_task.c nasa/cFE#1638, Expand FS Header Functional tests. nasa/cFE#1637, Complete coverage for cfe_es_start.c and cfe_es_syslog.c nasa/osal#1081, add range to OS_TaskDelay checks nasa/osal#1085, return OS_OBJECT_ID_UNDEFINED for root task ID on RTEMS nasa/osal#1090, increase UT symbol dump size limit nasa/osal#1091, do not register RTOS timer for external sync nasa/osal#1093, avoid task delete during UtPrintf nasa/osal#1097, Add osal prefix to Network API group nasa/osal#1092, increase timeout in network-api-test Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com> Co-authored-by: Himanshu <himanshu007-creator@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #468
Test the following cases:
Testing performed
Manually ran unit tests for ES: $ make -C build/native/default_cpu1/es test
Verified coverage on files with gcov cfe_es_task.c.gcno and gcov cfe_es_task.c.gcno
Expected behavior changes
Increased coverage percentage.
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Jose F. Martinez Pedraza/NASA GSFC