Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2196, resolve static analysis errors in tbl_UT.c #2197

Merged
merged 1 commit into from Nov 14, 2022

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Nov 3, 2022

Checklist (Please check before submitting)

Describe the contribution
Resolves two uninitialized variable errors reported in the workflow.

Fixes #2196

Testing performed
Build and run all tests
Run workflow

Expected behavior changes
Passes static analysis, no behavior change.

System(s) tested on
Updated Github workflow (with nasa/cFS#607)

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey
Copy link
Contributor Author

jphickey commented Nov 3, 2022

Running the latest static analysis workflow revealed the following additional style errors (this is from the "strict" set that does not occur at the bundle level workflow).

severity file line issue
style modules/fs/fsw/src/cfe_fs_api.c 142 Condition '((char)(&EndianCheck))==0x04' is always false
style modules/fs/fsw/src/cfe_fs_api.c 234 Condition '((char)(&EndianCheck))==0x04' is always false
style modules/fs/fsw/src/cfe_fs_api.c 249 Condition '((char)(&EndianCheck))==0x04' is always false
style modules/fs/fsw/src/cfe_fs_api.c 293 Condition '((char)(&EndianCheck))==0x04' is always false
style modules/sb/fsw/src/cfe_sb_priv.h 567 Parameter 'List' can be declared with const
style modules/sb/fsw/src/cfe_sb_priv.h 567 Parameter 'Node' can be declared with const
style modules/tbl/fsw/src/cfe_tbl_internal.c 1116 Condition '((char)&EndianCheck)==0x04' is always false

@jphickey
Copy link
Contributor Author

jphickey commented Nov 3, 2022

Clean cppcheck run observed in: https://github.com/nasa/cFE/actions/runs/3386994564

Resolves two uninitialized variable errors reported in the workflow,
and other minor style items.  Add suppressions for endian checks
which are constant on a given arch.
@jphickey
Copy link
Contributor Author

jphickey commented Nov 3, 2022

Updated commit includes style fixes, so this should pass static analysis after nasa/cFS#607 gets merged.

@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Nov 3, 2022
@jphickey jphickey marked this pull request as ready for review November 3, 2022 15:34
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Nov 3, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 14, 2022
*Combines:*

cfe v7.0.0-rc4+dev205
osal v6.0.0-rc4+dev151
cFS-GroundSystem v3.0.0-rc4+dev39

**Includes:**

*cFS*
- #608

*cFE*
- nasa/cFE#2197

*osal*
- nasa/osal#1323

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#217
- nasa/cFS-GroundSystem#230

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored-by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored-by: Paul Ober <paulober@users.noreply.github.com>
@dzbaker dzbaker merged commit c0baee1 into nasa:main Nov 14, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 14, 2022
*Combines:*

cfe v7.0.0-rc4+dev205
osal v6.0.0-rc4+dev151
cFS-GroundSystem v3.0.0-rc4+dev39

**Includes:**

*cFS*
- #608

*cFE*
- nasa/cFE#2197

*osal*
- nasa/osal#1323

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#217
- nasa/cFS-GroundSystem#230

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored-by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored-by: Paul Ober <paulober@users.noreply.github.com>
@jphickey jphickey deleted the fix-2196-cppcheck branch November 30, 2022 15:09
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cppcheck errors reported using latest workflow update
3 participants