Fix #607, rework static-analysis workflow #608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Updates the static analysis workflow:
Fixes #607
Testing performed
Update OSAL static analysis to point to this updated reusable workflow instead of the current one (nasa/cFS main) and check results.
Expected behavior changes
More complete/thorough results, while being a simpler workflow overall
System(s) tested on
Github workflow runner (Ubuntu image)
Additional context
This uses the updated baseline, and the cppcheck tool reports more errors than the old version did. So repos that referred to this workflow in the past may have new errors now.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.