Fix #1322, add BUGCHECK_VOID macro #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a variant of the BUGCHECK macro that has no return value argument, which can be used in functions with no return value without the unusual syntax appearing in the code.
jphickey
added
the
CCB:Ready
dzbaker
approved these changes
Oct 28, 2022
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 14, 2022
*Combines:* cfe v7.0.0-rc4+dev205 osal v6.0.0-rc4+dev151 cFS-GroundSystem v3.0.0-rc4+dev39 **Includes:** *cFS* - #608 *cFE* - nasa/cFE#2197 *osal* - nasa/osal#1323 *cFS-GroundSystem* - nasa/cFS-GroundSystem#217 - nasa/cFS-GroundSystem#230 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored-by: Paul Ober <paulober@users.noreply.github.com>
This was referenced Nov 14, 2022
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 14, 2022
*Combines:* cfe v7.0.0-rc4+dev205 osal v6.0.0-rc4+dev151 cFS-GroundSystem v3.0.0-rc4+dev39 **Includes:** *cFS* - #608 *cFE* - nasa/cFE#2197 *osal* - nasa/osal#1323 *cFS-GroundSystem* - nasa/cFS-GroundSystem#217 - nasa/cFS-GroundSystem#230 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored-by: Paul Ober <paulober@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Adds a variant of the BUGCHECK macro that has no return value argument, which can be used in functions with no return value without the unusual syntax appearing in the code.
Fixes #1322
Testing performed
Basic build and run tests
Run cppcheck against source
Expected behavior changes
Cppcheck does not report a syntax error
System(s) tested on
Ubuntu 22.04 (using cppcheck v2.7)
Additional context
Just a wrapper macro is enough to satisfy cppcheck. Added a note that the missing second argument (return value) is intentional on a void function.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.