Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few size variables could be updated to size_t or CF_ChunkSize_t #390

Closed
2 tasks done
thnkslprpt opened this issue Jun 13, 2023 · 0 comments · Fixed by #391
Closed
2 tasks done

A few size variables could be updated to size_t or CF_ChunkSize_t #390

thnkslprpt opened this issue Jun 13, 2023 · 0 comments · Fixed by #391

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
A few variables in CF could be updated to the more expressive size_t or CF_ChunkSize_t types

Code snips
val should be of CF_ChunkSize_t type:

CFE_Status_t CF_CmdValidateChunkSize(uint32 val, uint8 chan_num);

size should be of size_t type:

CF/fsw/src/cf_cmd.c

Lines 942 to 947 in 0f18ae4

struct
{
void * ptr;
uint32 size;
int (*fn)(uint32, uint8 chan_num);
} item;

...and few others.

Expected behavior
Update where appropriate

Reporter Info
Avi Weiss @thnkslprpt

thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Jun 13, 2023
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Jun 15, 2023
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Jun 15, 2023
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Oct 26, 2023
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Dec 13, 2023
@dzbaker dzbaker closed this as completed in 5f768d4 Feb 8, 2024
dzbaker added a commit that referenced this issue Feb 8, 2024
…-to-typedefs

Fix #390, Update size variables to `size_t` and `CF_ChunkSize_t` typedefs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants