Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #793, Clarify restart/reload app behavior #1083

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 11, 2021

Describe the contribution
Fix #793 - Clarifies the difference between restart and reload in API/cmd and user's guide documentation

Testing performed
None, comments only

Expected behavior changes
None

System(s) tested on
N/A

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) docs This change only affects documentation. labels Jan 11, 2021
@skliper skliper added this to the 7.0.0 milestone Jan 11, 2021
@skliper
Copy link
Contributor Author

skliper commented Jan 12, 2021

After reviewing #915 and testing the current behavior, these documentation updates may be premature if the fix for #915 is to check for file existence as part of command processing.

@astrogeco
Copy link
Contributor

CCB:2021-01-13

Also see #915 for context

@skliper skliper marked this pull request as draft January 13, 2021 19:44
@skliper skliper changed the title Fix #793, Clarify restart/reload app behavior WIP - Fix #793, Clarify restart/reload app behavior Jan 13, 2021
@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 13, 2021
@skliper
Copy link
Contributor Author

skliper commented Jan 25, 2021

Refactored based on #1128 and resolution of #915, ready to go.

@skliper skliper marked this pull request as ready for review January 25, 2021 22:59
@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 25, 2021
@skliper skliper changed the title WIP - Fix #793, Clarify restart/reload app behavior Fix #793, Clarify restart/reload app behavior Jan 25, 2021
@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 27, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate February 3, 2021 15:08
@astrogeco astrogeco merged commit 11201fa into nasa:integration-candidate Feb 3, 2021
@skliper skliper deleted the fix793-reload_restart_doc branch April 1, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change only affects documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFE RELOAD and RESTART commands handled (almost) identically
2 participants