Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cFE Integration candidate: 2021-01-12 #1088

Merged
merged 11 commits into from
Jan 13, 2021
Merged

cFE Integration candidate: 2021-01-12 #1088

merged 11 commits into from
Jan 13, 2021

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Jan 12, 2021

Describe the contribution

Fix #1049, replace OS_fsBlocksFree
Fix #1051, use OSAL time conversion/access methods
Fix #1062, remove CFE_SB_TimeOut_t typedef
Fix #260, Remove unused network_includes.h
Fix #1081, Correct deprecation directive typo

Testing performed
See https://github.com/nasa/cFS/pull/174/checks

Expected behavior changes

PR #1050 - Replace OS_FileSysStatVolume() withOS_fsBlocksFree() which will be deprecated. This call reports the number of total blocks, not just the free blocks, making the check more accurate and removing the need for a workaround for desktop machines.

PR #1058 - Instead of accessing OS_time_t values directly, use the OSAL-provided conversion and access methods. This provides independence and abstraction from the specific OS_time_t definition and allows OSAL to transition to a 64 bit value.

PR #1063 - Removes the spurious CFE_SB_TimeOut_t typedef from cfe_sb.h. May affect any apps that inappropriately rely on the private typedef.

PR #1067 - Removes unused network_includes.h. Not used by the framework anywhere, apps should use OSAL Socket APIs instead.

PR #1082 - Fixes deprecation directive typos

System(s) tested on
Ubuntu 18.04

Additional context
Part of nasa/cFS#174

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
@skliper
@jphickey
@CDKnightNASA

jphickey and others added 10 commits December 29, 2020 15:23
Use OS_FileSysStatVolume() instead.  This also enables the check
to be more appropriate as this call reports the number of total
blocks, not just the free blocks, so no workaround for desktop
machines is needed.
Instead of accessing OS_time_t values directly, use the
OSAL-provided conversion and access methods.  This provides
independence/abstraction from the specific OS_time_t
definition and allows OSAL to transition to a 64 bit value.
Fix #1051, use OSAL time conversion/access methods
Fix #1081, Correct deprecation directive typo
@astrogeco astrogeco marked this pull request as ready for review January 13, 2021 16:44
@astrogeco astrogeco merged commit c7363c8 into main Jan 13, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 13, 2021
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment