Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda versioning #1013

Closed
matthewhanson opened this issue May 23, 2019 · 4 comments
Closed

Lambda versioning #1013

matthewhanson opened this issue May 23, 2019 · 4 comments
Assignees

Comments

@matthewhanson
Copy link

The information in the docs for Lambda versioning is incorrect:
https://github.com/nasa/cumulus/blob/master/docs/lambda_versioning.md

In that there is no supported field uniqueIdentifier under s2Source for Lambdas, and instead an error will be thrown if provided.

I'm not sure if that means the rest of the document is still relevant, does the versioning still happen like described here? Does it use the s3Source key field instead as an identifier?

@Jkovarik
Copy link
Member

Jkovarik commented May 23, 2019

The uniqueIdentifer field is, or should be supported under s3source. We're using it in our example/integration deployments here: https://github.com/nasa/cumulus/blob/master/example/lambdas.yml, for example. Please also note from the docs: That key, due to AWS constraints, must be letters ([a-zA-Z]) only.

What is the error thrown and/or can you provide an example of the lambda configuration you're using?

@Jkovarik Jkovarik self-assigned this May 23, 2019
@matthewhanson
Copy link
Author

Ok, the error I thought was just "uniqueIdentifier" not supported, but it could have been complaining about me not abiding by the restrictions for that key. I'll test this again tomorrow and report back. Thanks for the response!

@matthewhanson
Copy link
Author

This works, thanks @Jkovarik and sorry for the confusion.

@Jkovarik
Copy link
Member

Awesome! Happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants