Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in PostgreSQL Deployment docs #2378

Closed
michaeljb opened this issue Jul 16, 2021 · 1 comment
Closed

Broken link in PostgreSQL Deployment docs #2378

michaeljb opened this issue Jul 16, 2021 · 1 comment

Comments

@michaeljb
Copy link
Contributor

From the Overview section, paragraph 5, on PostgreSQL Database Deployment:

We have provided an example terraform deployment using this module in the Cumulus template-deploy repository on github.

The "Cumulus template-deploy repository" link points to https://github.com/nasa/cumulus-template-deploy/rds-cluster-tf/ which 404's; it should be pointing to https://github.com/nasa/cumulus-template-deploy/tree/master/rds-cluster-tf or perhaps something like https://github.com/nasa/cumulus-template-deploy/tree/f3684f73ce5c784939dc13607bcb78aa57e0c59e/rds-cluster-tf if a more permanent link is desired (the master link could break with further code changes).

I'm happy to open a PR to fix this, but I don't know which version of the fixed link is preferred.

@michaeljb michaeljb changed the title Broken link in docs Broken link in PostgreSQL Deployment docs Jul 16, 2021
@markdboyd
Copy link
Contributor

markdboyd commented Jul 16, 2021

@michaeljb Thanks! Yeah I'd say adding a link to https://github.com/nasa/cumulus-template-deploy/tree/master/rds-cluster-tf should be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants