Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-2672: Lazy load Timeline component #1219

Closed
mreese84 opened this issue Oct 1, 2020 · 2 comments · Fixed by #1235
Closed

EDSC-2672: Lazy load Timeline component #1219

mreese84 opened this issue Oct 1, 2020 · 2 comments · Fixed by #1235

Comments

@mreese84
Copy link
Contributor

mreese84 commented Oct 1, 2020

Description

In an effort to improve initial load times, we should lazy load the Timeline component. We want to be sure to do this in a way that does not degrade the UX of the initial application load.

Acceptance Criteria

  • Timeline javascript is only loaded in pages that render the timeline (/search/granules, /project)
@sofiarivas
Copy link
Contributor

Hi @mreese84 I need to take a closer look at the codebase but I think this could be accomplished with React.suspense https://web.dev/code-splitting-suspense/

If this is the case I can work on this issue 🙂

@trevorlang
Copy link
Collaborator

trevorlang commented Oct 1, 2020

@sofiarivas, thats correct! We have React lazy/suspense implemented in a few other places throughout the application if you would like some prior art.

At first look, it seems like this could be implemented in the TimelineContainer component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants