Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should error if output name does not match input name #79

Open
jphickey opened this issue May 18, 2021 · 0 comments
Open

Should error if output name does not match input name #79

jphickey opened this issue May 18, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The cFE build scripts assume that the file name of the output of elf2cfetbl matches the input basename but with a .tbl extension added.

In reality, this tool uses the output name specified in the source file. If this doesn't match, an obscure installation error occurs because the "expected" binary file will be missing.

Describe the solution you'd like
elf2cfetbl should error out if the input name does not match the output name.

Describe alternatives you've considered
Alternatively, the tool could have a new command line option added to directly control the output name and override whatever was in the source file. This would be a more substantial change, however.

Additional context
This can create confusion when the multiple table feature in nasa/cFE#1538 is used. If the source file internal definition doesn't match the expected name the error occurs later at install time, not when elf2cfetbl runs, so it can be confusing.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants