Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOCTOU bug for chmod #90

Open
ArielSAdamsNASA opened this issue Sep 27, 2021 · 0 comments
Open

TOCTOU bug for chmod #90

ArielSAdamsNASA opened this issue Sep 27, 2021 · 0 comments

Comments

@ArielSAdamsNASA
Copy link

Describe the bug
Calling function chmod that uses DstFilename after a check function. This can cause a time-of-check, time-of-use race condition

Expected behavior
Use fchmod as seen in OS_FileChmod_Impl.

Code snips

elf2cfetbl/elf2cfetbl.c

Line 1460 in 10f55fb

chmod(DstFilename, dststat.st_mode & ~(S_IRGRP | S_IWGRP | S_IXGRP | S_IROTH | S_IWOTH | S_IXOTH));

System observed on:
Coverity: https://scan.coverity.com/projects/arielsadamsnasa-cfs-jsf-rules?tab=overview

Reporter Info
Ariel Adams, ASRC Federal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ArielSAdamsNASA