Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #168

Closed
elfring opened this issue Mar 11, 2015 · 2 comments
Closed

reserved identifier violation #168

elfring opened this issue Mar 11, 2015 · 2 comments

Comments

@elfring
Copy link

elfring commented Mar 11, 2015

I would like to point out that identifiers like "_H_ModuleLight" and "_H_ModuleResource" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
@miatauro-NASA
Copy link
Contributor

Addressed in 63e2c96. I'm surprised none of the compilers complained about this. Thanks! I'm always looking to improve standards compliance and general code quality.

@elfring
Copy link
Author

elfring commented Mar 27, 2015

Thanks for your improvement of affected include guards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @miatauro-NASA