adding default cmake settings #105
Conversation
|
@kevin-f-ortega I added a fix to for the missing test case. Formatting is at the whim of our formatter. |
|
Totally late and very optional feedback, but I was wondering if using YAML list instead of newlines to separate options might be a bit cleaner and simpler? I think this is generally a more common YAML practice, I've never actually seen multiline strings without quotes like this before, though it does seem to work fine! Ex: default_cmake_options:
- OPTION1=ABC
- OPTION2=123
- OPTION3=Somethinginstead of: default_cmake_options: OPTION1=ABC
OPTION2=123
OPTION3=SomethingI figured I might bring this up before this feature goes into regular use and we have to start thinking about backwards compatibility concerns. |
| @@ -311,6 +311,9 @@ def get_cmake_args(self) -> dict: | |||
| if self.get_settings(setting, None) is not None | |||
| } | |||
|
|
|||
| # Load in the default settings | |||
| self.get_settings("default_cmake_options", None) | |||
There was a problem hiding this comment.
@LeStarch this line doesn't seem to do anything, yet it can be misleading to think that it does (as this could potentially tweak the order in which arguments are loaded in). Can you confirm? If so, I'll remove it
There was a problem hiding this comment.
I was looking at this when reviewing #165. Also I don't disagree with Josh's comment above but it may be a little late to switch
Change Description
Enables users to set the
default_cmake_optionssettings.inifield to pass in default cmake options.