Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Default -D flags to settings.ini #1683

Closed
LeStarch opened this issue Sep 30, 2022 · 2 comments · Fixed by nasa/fprime-tools#105
Closed

Add Default -D flags to settings.ini #1683

LeStarch opened this issue Sep 30, 2022 · 2 comments · Fixed by nasa/fprime-tools#105
Labels
enhancement High Priority High Priority issue that needs to be resolved.

Comments

@LeStarch
Copy link
Collaborator

F´ Version
Affected Component

Feature Description

settings.ini should allow a default set of -D flags to submit to a CMake call.

@LeStarch LeStarch added enhancement High Priority High Priority issue that needs to be resolved. labels Sep 30, 2022
@SterlingPeet
Copy link
Contributor

I have run into a need for this across several projects. The problem manifests when there are several similar targets with slightly different hardware setups, such as different clock speeds.

The workaround has been to use separate toolchain wrapper files in cmake, but then someone with “special” knowledge must go and do this every time a new variation is required.

Ideally a single toolchain file would be used, and it would be configurable via -D options that are kept in the project, because this cleanly separates the concerns of the project’s specific target configuration and the toolchain setup logic that serves a family of target platforms.

@LeStarch
Copy link
Collaborator Author

Closed by nasa/fprime-tools#105

@LeStarch LeStarch linked a pull request Nov 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement High Priority High Priority issue that needs to be resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants