Fix arguments order for generate stage

[SMorettini]

Originating Project/Creator
Affected Component	fprime-util generate

---

Change Description

Cmake arguments come from three different places:

1. default
2. settings.ini
3. user-defined arguments when running fprime-util generate

Before this change, the order was the default, user-defined and settings.ini. Now I changed the order as reported above.

Rationale

I was trying to set the -DCMAKE_BUILD_TYPE=Release during the generation of the unit tests but I was not able to send anything else than Debug. This was happening because when the arguments were read from settings.ini, the build type was put by default to Debug. This overrides the build type set from the command line.

With my change, the user-defined variable when running fprime-util generate ... overrides any other variable.

[thomas-bc]

LGTM! Agreed that CLI args should take precedence.

[thomas-bc]

@SMorettini turns out the order of dictionary unpacking was a conscious decision, as users should not override the FPRIME_* variables from get_cmake_args() through the command line, but instead use the settings.ini file. Otherwise issues can arise. This means CMAKE_BUILD_TYPE should not be set as part of the get_cmake_args() call, but rather at the generate() level.

I went ahead and implemented this in your PR branch, I hope you don't mind. Would you want to give this a quick review?

I tested locally and it should behave as you requested. Would very much appreciate some additional eyes on this though!
Thanks!

[thomas-bc]

Merging, let me know if you have any comments!

[SMorettini]

@thomas-bc I originally opened this pull request to give the possibility to build UTs using a CMAKE_BUILD_TYPE different from Debug. I agree with your changes but if I understand correctly the code, you reintroduced back the problem I wanted to remove.

Am I right or the CMAKE_BUILD_TYPE will be always Debug if the UTs are built? Is that something that we want by design? I think that the user should have the flexibility to choose the CMAKE_BUILD_TYPE in any case.
If by design we don't want to give this flexibility then we should document it somewhere because, at least for me, it seems a hidden and unexpected feature.

[SMorettini]

@thomas-bc do you have any comments about this?

[LeStarch]

For newer versions of F´ (v3+) it only defaults to debug if the user has not set "CMAKE_BUILD_TYPE"

[LeStarch]

I tested this and a custom build type does carry into a UT cache!