Update/new data models #67

LeStarch · 2022-05-03T21:30:21Z


*Originating Project/Creator*
*Affected Component*
*Affected Architectures(s)*
*Related Issue(s)*
*Has Unit Tests (y/n)*
*Builds Without Errors (y/n)*
*Unit Tests Pass (y/n)*
*Documentation Included (y/n)*

Change Description

New more efficient data model architecture.

github-actions · 2022-05-03T21:30:45Z

@check-spelling-bot Report

Unrecognized words, please review:

attr
baes
Consturct
excluede
issubclass
lenght
optionaly
primitave
stiring
tmp

Previously acknowledged words that are now absent

Autocoders deepcopy Dxyz filecmp isnumeric LGTM mkdtemp params Prm README rmd Serializables sset tempfile Tlm

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:LeStarch/fprime-tools.git repository
on the update/new-data-models branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/fprime-community/fprime-tools/issues/comments/1116679214" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

github-actions · 2022-05-03T21:31:57Z

@check-spelling-bot Report

Unrecognized words, please review:

attr
primative

Previously acknowledged words that are now absent

Autocoders deepcopy Dxyz filecmp isnumeric LGTM mkdtemp params Prm README rmd Serializables sset tempfile Tlm

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:LeStarch/fprime-tools.git repository
on the update/new-data-models branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/fprime-community/fprime-tools/issues/comments/1116680174" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

lgtm-com · 2022-05-03T21:46:26Z

This pull request introduces 4 alerts when merging a97738e into 41d2957 - view on LGTM.com

new alerts:

3 for Unused import
1 for Suspicious unused loop iteration variable

github-actions · 2022-05-09T15:50:10Z

@check-spelling-bot Report

Unrecognized words, please review:

lld

Previously acknowledged words that are now absent

ASer Autocoders deepcopy Dxyz filecmp isnumeric LGTM mkdtemp params Prm README rmd Serializables sset tempfile Tlm

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:LeStarch/fprime-tools.git repository
on the update/new-data-models branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/fprime-community/fprime-tools/issues/comments/1121275637" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

lgtm-com · 2022-05-09T16:07:37Z

This pull request introduces 6 alerts when merging 1c45abf into d53e5aa - view on LGTM.com

new alerts:

4 for Unused import
2 for `__eq__` not overridden when adding attributes

lgtm-com · 2022-05-09T16:17:32Z

This pull request introduces 6 alerts when merging cdb6818 into d53e5aa - view on LGTM.com

new alerts:

4 for Unused import
2 for `__eq__` not overridden when adding attributes

lgtm-com · 2022-05-09T16:52:13Z

This pull request introduces 1 alert when merging b3efca4 into d53e5aa - view on LGTM.com

new alerts:

1 for `__eq__` not overridden when adding attributes

lgtm-com · 2022-05-09T17:18:05Z

This pull request introduces 1 alert and fixes 2 when merging ff3a181 into d53e5aa - view on LGTM.com

new alerts:

1 for `__eq__` not overridden when adding attributes

fixed alerts:

1 for Unused local variable
1 for Unused import

lgtm-com · 2022-05-09T17:54:52Z

This pull request fixes 2 alerts when merging 9b8d0d3 into d53e5aa - view on LGTM.com

fixed alerts:

1 for Unused local variable
1 for Unused import

src/fprime/common/models/serialize/type_base.py

src/fprime/common/models/serialize/array_type.py

src/fprime/common/models/serialize/bool_type.py

src/fprime/common/models/serialize/enum_type.py

src/fprime/common/models/serialize/numerical_types.py

src/fprime/common/models/serialize/serializable_type.py

test/fprime/common/models/serialize/test_types.py

kevin-f-ortega

This looks good. I added some comments.

github-actions · 2022-05-11T01:33:43Z

@check-spelling-bot Report

Unrecognized words, please review:

abcd
Dictionay
subserializable

Previously acknowledged words that are now absent

ASer Autocoders deepcopy Dxyz filecmp isnumeric IUF LGTM mkdtemp params Prm README rmd Serializables sset tempfile Tlm

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:LeStarch/fprime-tools.git repository
on the update/new-data-models branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/fprime-community/fprime-tools/issues/comments/1123083981" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

LeStarch · 2022-05-11T01:37:57Z

@kevin-f-ortega I Think I fixed everything. Care to review my last few commits?

lgtm-com · 2022-05-11T01:48:07Z

This pull request fixes 2 alerts when merging 822149a into d53e5aa - view on LGTM.com

fixed alerts:

1 for Unused local variable
1 for Unused import

lgtm-com · 2022-05-12T17:46:38Z

This pull request fixes 2 alerts when merging d5736e5 into d53e5aa - view on LGTM.com

fixed alerts:

1 for Unused local variable
1 for Unused import

lgtm-com · 2022-05-12T18:11:35Z

This pull request fixes 2 alerts when merging 593a483 into d53e5aa - view on LGTM.com

fixed alerts:

1 for Unused local variable
1 for Unused import

kevin-f-ortega

Good job @LeStarch !

LeStarch added 3 commits May 3, 2022 14:17

lestarch: refactoring data model architecture to avoid deepcopies

8f17a5b

mstarch: bug fixes for refactored type setup

c1272d3

lestarch: formatted new data model architecture

659dd26

lestarch: sp

a97738e

LeStarch force-pushed the update/new-data-models branch from cbf049f to a97738e Compare May 3, 2022 21:35

LeStarch added 2 commits May 5, 2022 13:44

lestarch: fixing UTs, models consistency

f737b8e

lestarch: better models UTs and fixes there in

1d5e811

lestarch: sp

1c45abf

lestarch: formatting

cdb6818

lestarch: fixing static analysis errors

b3efca4

lestarch: more static analysis fixes

ff3a181

lestarch: no more .val usage in BoolType implementation

9b8d0d3