lestarch: inconsistency after deserialization

nasa · May 12, 2022 · d5736e5 · d5736e5
1 parent 822149a
commit d5736e5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/fprime/common/models/serialize/array_type.py b/src/fprime/common/models/serialize/array_type.py
@@ -116,8 +116,8 @@ def deserialize(self, data, offset):
             item = self.MEMBER_TYPE()
             item.deserialize(data, offset)
             offset += item.getSize()
-            values.append(item.val)
-        self.val = values
+            values.append(item)
+        self._val = values
 
     def getSize(self):
         """Return the size of the array"""

diff --git a/test/fprime/common/models/serialize/test_types.py b/test/fprime/common/models/serialize/test_types.py
@@ -101,7 +101,10 @@ def valid_values_test(type_input, valid_values, sizes):
             deserializer.deserialize((b" " * offset) + serialized, offset)
             assert instantiation.val == deserializer.val, "Deserialization has failed"
             assert deserializer.getSize() == size
-
+            # Check another get/set pair and serialization of the post-deserialized object
+            deserializer.val = deserializer.val
+            new_serialized_bytes = deserializer.serialize()
+            assert serialized == new_serialized_bytes, "Repeated serialization has failed"
 
 def invalid_values_test(
     type_input, invalid_values, exception_class=TypeMismatchException