Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

negative degrees not correctly converted #4

Closed
snoyes opened this issue Aug 29, 2022 · 2 comments
Closed

negative degrees not correctly converted #4

snoyes opened this issue Aug 29, 2022 · 2 comments

Comments

@snoyes
Copy link
Contributor

snoyes commented Aug 29, 2022

https://github.com/nasa/HyperInSPACE/blob/951206f742dd280db7f8d4ad2722bdce6f55a2c5/Source/Utilities.py#L187-L193

-0.05 degrees is 3 minutes (South or West).
ddToDm(-0.05) returns 3.0, meaning 3 minutes (North or East).

-1.05 degrees is 1 degree 3 minutes (South or West).
ddToDm(-1.05) returns -97.0, meaning 97 minutes (South or West), equivalent to 1 degree 37 minutes.
snoyes added a commit to snoyes/HyperInSPACE that referenced this issue Aug 29, 2022
@snoyes
Correctly convert negative deg to deg min
0962b40 
Fix issue nasa#4
@snoyes snoyes mentioned this issue Aug 29, 2022
Merged
@oceancolorcoder
Copy link
Contributor

Thank you for pointing this out. This method is a very old and long uncalled remnant and will be removed.

oceancolorcoder pushed a commit that referenced this issue Aug 29, 2022
@snoyes @oceancolorcoder
Correctly convert negative deg to deg min
1b18b6b 
Fix issue #4
@oceancolorcoder
Copy link
Contributor

I changed my mind and left it in for testing. Correction implemented with patch-1 pull request. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snoyes @oceancolorcoder