Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert isort call in pre-commit to ensure consistent errors with CI linter #123

Closed
trey0 opened this issue Jan 18, 2024 · 2 comments
Closed
Assignees

Comments

@trey0
Copy link
Contributor

trey0 commented Jan 18, 2024

The isort pre-commit call was edited here so that it calls isort only on changed files rather than recursively on the whole repo.

But there was a comment just above that line explaining in absurd detail why we are calling it recursively on the whole repo...

@trey0
Copy link
Contributor Author

trey0 commented Jan 18, 2024

Note that if the motivation for the change was to exclude submodules from linting, it looks like that can be done with the --extend-skip flag as used in the corresponding call in the astrobee repo.

@trey0
Copy link
Contributor Author

trey0 commented Feb 6, 2024

Forgot to note this was fixed as part of 7d7852b

@trey0 trey0 closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants