Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize JEM bay motions for robustness and speed #142

Closed
trey0 opened this issue Feb 16, 2024 · 3 comments · Fixed by #147 or #146
Closed

Optimize JEM bay motions for robustness and speed #142

trey0 opened this issue Feb 16, 2024 · 3 comments · Fixed by #147 or #146
Assignees

Comments

@trey0
Copy link
Contributor

trey0 commented Feb 16, 2024

Currently, the JEM bay motions of the survey planner are not well-optimized.

The following issues are observed:

  • If the robot is moving multiple bays, it includes unnecessary rotations at each motion because it flies in face-forward mode and each pose has its attitude set to point the robot in the +X direction. Therefore, when flying multiple waypoints down the JEM centerline, at each waypoint, the robot turns 90 degrees to face +X, then turns back down the centerline. These rotations waste time and more importantly can negatively impact localization.
  • The poses are not following our typical recent guidance for how to optimize localization in the JEM, which is more or less to face the robot toward whichever end of the module is closest. (Roughly, point toward the airlock for JEM bay 4 and up, point toward the NOD2 hatch for JEM bay 3 and down.)

The following improvements are proposed:

  • Adjust attitude of JEM bay poses here to follow the localization guidance.
  • Turn off face-forward motion. Will think about the easiest approach for this. I think it would be ok for this to be a blanket change rather than configurable per position because we have been pretty consistent about wanting to avoid unnecessary point turns that could affect localization.
@trey0 trey0 self-assigned this Feb 16, 2024
@marinagmoreira
Copy link
Member

By default during startup, the face-forward mode is turned off. You can mimic this behavior in simulation by turning off the option in the GDS Teleop menu.

@trey0
Copy link
Contributor Author

trey0 commented Feb 16, 2024

By default during startup, the face-forward mode is turned off. You can mimic this behavior in simulation by turning off the option in the GDS Teleop menu.

Good to know! But I'd also like to clarify. By "startup" I guess you mean a manual step earlier in the relevant ground procedure, not for example something that happens automatically through running roslaunch or other steps already documented in the multi-robot sim instructions.

@marinagmoreira
Copy link
Member

By default during startup, the face-forward mode is turned off. You can mimic this behavior in simulation by turning off the option in the GDS Teleop menu.

Good to know! But I'd also like to clarify. By "startup" I guess you mean a manual step earlier in the relevant ground procedure, not for example something that happens automatically through running roslaunch or other steps already documented in the multi-robot sim instructions.

On the robots when we start the fsw with ./isaac_scripts/ground_prep.bash 0.2.7+focal1 isaac13 survey comms that includes running a startup.fplan that sets up those things (also the recording profile). It's not a manual separate step as that would be too time consuming for ops.

@marinagmoreira marinagmoreira linked a pull request Feb 17, 2024 that will close this issue
@marinagmoreira marinagmoreira linked a pull request Feb 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants