-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Production] UI Symbols font updates branch prod-uisymbols #188
Comments
open #188 Added icon-dataset e611;
Cherry-picked into open187 for #187 and github.jpl.85 https://github.jpl.nasa.gov/MissionControl/vista/issues/85 |
@charlesh88 I think we just lost glyphs in VISTA because this hasn't been added to open-master. when is this branch ready to merge? |
I don't regularly merge this branch into master; I created this branch as a way to have a place where I always have the latest symbol fonts and production config file for the tool I use. Typically, I add new symbols while working in a topic branch. I actually do the work first in prod-uisymbols, then cherry-pick that commit into my topic branch. When the topic branch is merged into master, the new font files become available. I don't however keep the rest of the branch up to date with master, hence the cherry-picking. Having written all this down, it may make more sense to keep a completely separate repo for this code. If anyone has thoughts on this, let me know. I'm not sure how we'd would lose glyphs; the only thing I could think of is I or someone else messed up a merge in a topic branch that I worked on and didn't bring in the updated font files. As always, I'm up for suggestions on ways to do this better. Also, you can definitely always depend that this branch has the latest symbols files. |
@VWoeltjen Ahh, should have read Victor's email "Re. VISTA glyphs" - that's how we lost the glyphs. |
Charles and I talked about this a bit in the lab-- aside from requiring additional reviews, there's no reason we wouldn't want to continually merge the most up-to-date version of the fonts into master. These pull requests should be very fast to resolve, and the individual commits can be cherry-picked into topic branches so they are immediately available in testing. Charles is working on updates to the font files and will be opening a request to bring those into master some time today. |
open #188 Jay request; e615 is no-gleam and replaces the crosshair glpyh; gleam version is e616
See #246 for pull request to update this. |
#246 was merged. |
open #188 See Google Doc UI Symbols Font Map for char codes
open #188 Removed wrongly placed new file; updated old file with latest project config;
open #188 Removed wrongly placed new file; updated old file with latest project config;
Not really being used anymore, closing. |
This branch acts as source control for the UI Symbols custom font. The latest version of the font config file plus updated fonts should always be maintained here, with updates cherry-picked into other topic branches as needed.
Symbols info must be updated as well at the UI Symbols Font Map Google doc: https://docs.google.com/spreadsheets/d/1078wA0N0zCQnBGZXz4Dj5PUuP_JoPgrMlIyshvkjO3s/edit#gid=0
The text was updated successfully, but these errors were encountered: