Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and integrate prod-uisymbols branch #246

Merged
merged 5 commits into from
Nov 6, 2015
Merged

Review and integrate prod-uisymbols branch #246

merged 5 commits into from
Nov 6, 2015

Conversation

charlesh88
Copy link
Contributor

#188 Don't delete prod-uisymbols after this integration, I intend to keep updating this branch on an ongoing basis.

Have merged latest master branch into prod-uisymbols, and have modified and added art for e615 and e616 glyphs accordingly. The Google font symbols map has been updated.

Author checklist:

  • Changes address original issue? Y
  • Unit tests included and/or updated with changes? N/A
  • Command line build passes? N/A
  • Expect to pass code review? N/A

@larkin
Copy link
Contributor

larkin commented Nov 6, 2015

Review Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? N/A (No changes)
  3. Code style and in-line documentation are appropriate? Y
  4. Commit messages meet standards? Y
  5. Project-specific information isolated to appropriate branches? Y

Integration Checklist

  1. Automated build passing after merge? Y
  2. No merge conflicts (or resolution trivial/obvious)? Y
  3. All master branches up-to-date after merge? Y
  4. Project-specific information isolated to appropriate branches? Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants