Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plot actions to save space #5201

Merged
merged 13 commits into from
May 20, 2022
Merged

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented May 13, 2022

Closes #4359

Describe your changes:

Move plot export PNG and JPG actions to the 3-dot menu.
Move plot toggle cursor and gridlines to the plot local controls section.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #5201 (f86c18b) into master (1ca5271) will decrease coverage by 0.04%.
The diff coverage is 37.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5201      +/-   ##
==========================================
- Coverage   50.21%   50.17%   -0.05%     
==========================================
  Files         546      548       +2     
  Lines       20071    20101      +30     
  Branches     1859     1859              
==========================================
+ Hits        10079    10085       +6     
- Misses       9508     9531      +23     
- Partials      484      485       +1     
Impacted Files Coverage Δ
src/exporters/ImageExporter.js 34.78% <ø> (ø)
src/plugins/plot/Plot.vue 38.46% <0.00%> (+2.74%) ⬆️
src/plugins/plot/PlotViewProvider.js 76.19% <0.00%> (-12.70%) ⬇️
...lugins/plot/overlayPlot/OverlayPlotViewProvider.js 14.28% <0.00%> (-3.90%) ⬇️
src/plugins/plot/stackedPlot/StackedPlot.vue 44.18% <0.00%> (-5.82%) ⬇️
...lugins/plot/stackedPlot/StackedPlotViewProvider.js 14.28% <0.00%> (-3.90%) ⬇️
src/plugins/plot/MctPlot.vue 52.00% <28.57%> (-0.31%) ⬇️
src/plugins/plot/stackedPlot/StackedPlotItem.vue 68.42% <50.00%> (-2.17%) ⬇️
src/plugins/plot/actions/ViewActions.js 75.00% <75.00%> (ø)
src/plugins/plot/actions/utils.js 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ca5271...f86c18b. Read the comment docs.

Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with these changes:

  • Moved cursor guides and grid toggle buttons.
    image
  • Fixed typo and improved image export dialog message.

@shefalijoshi shefalijoshi requested review from jvigliotta and michaelrogers and removed request for davetsay and jvigliotta May 20, 2022 13:49
Copy link
Contributor

@michaelrogers michaelrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactor looks good to me. The moved controls and png+jpg download work as expected when tested locally.

@shefalijoshi shefalijoshi enabled auto-merge (squash) May 20, 2022 18:37
@shefalijoshi shefalijoshi merged commit 4891656 into master May 20, 2022
@unlikelyzero unlikelyzero deleted the refactor-plots-actions branch May 20, 2022 19:13
@davetsay
Copy link
Contributor

Good stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move image export and cursor/grid toggle actions to action menu
5 participants