-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor plot actions to save space #5201
Conversation
…m toggle switch in action bar
…iminate-wasted-header-space-in-plot-views
Move cursor guide and toggle grid lines to local controls for plots (on hover)
Codecov Report
@@ Coverage Diff @@
## master #5201 +/- ##
==========================================
- Coverage 50.21% 50.17% -0.05%
==========================================
Files 546 548 +2
Lines 20071 20101 +30
Branches 1859 1859
==========================================
+ Hits 10079 10085 +6
- Misses 9508 9531 +23
- Partials 484 485 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refactor looks good to me. The moved controls and png+jpg download work as expected when tested locally.
Good stuff |
Closes #4359
Describe your changes:
Move plot export PNG and JPG actions to the 3-dot menu.
Move plot toggle cursor and gridlines to the plot local controls section.
All Submissions:
Author Checklist
Reviewer Checklist