Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show telemetry end point full path on hover #6656

Closed
charlesh88 opened this issue May 10, 2023 · 4 comments · Fixed by #6756
Closed

Show telemetry end point full path on hover #6656

charlesh88 opened this issue May 10, 2023 · 4 comments · Fixed by #6756
Labels
type:feature Feature. Required intentional design
Milestone

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented May 10, 2023

Is your feature request related to a problem? Please describe.
Open MCT has multiple places that display the names of telemetry end points, such as the tree, layout elements (alphanumerics, frame titles) plot legends and the Elements Pool when editing. Many telemetry points have the same name (enabledFlag, errCounter, etc.) and can only be distinguished by the sub-system they reside in. Open MCT however, doesn't provide good or quick ways to determine the enclosing path structure for a given end point, making it arduous and impossible in certain instances to determine where an end point is deriving from.

Describe the solution you'd like

  • Show an object's full path to its original (not aliased) location, and its name, when hovering over a variety of elements, listed below.
  • IMPORTANT Don't use tooltips for this such that the element always shows on hover - this could become very distracting or possibly obscure data in dense displays. Instead, allow a keyboard modifier (like "i" or "?") that will then display a popup on hover while that key is being pressed.
  • The format would use space-slash-space to separate and list out parent nodes and the object's name, e.g. Dictionary / Rover Telem / FooIo / BarEnabled.
  • For hovered root-level elements, we could display "Root element" or something similar.
  • This should apply to composable objects as well as non-composable.

List of elements to be supported:
P1

  • The "object label" component: a single change here gives us coverage in multiple locations including trees, Recent Items, the Inspector and the Elements Pool.
  • Alphanumerics in Display Layouts, for all display styles (label + value, value only, etc.)
  • Conditional widgets in Display Layouts
  • Cells in the "Name" column in Telemetry Tables. We currently use hover in this view to display full values for each cell that might be getting truncated, but the Name hover would be replaced with this approach.
  • LAD Tables should be brought into parity with the same hover strategy as Telemetry Tables and use the same approach as described.
  • Legends in all plot views that use them, both collapsed and expanded modes.
  • Display and Flexible Layout frame and Tab View headers.
  • Notebook embeds.
  • Time Strip constituents.
  • Search results main results and path items.

P2

  • Single-data-source views like Gauges and Scatter Plots: hovering the view should disclose the composition's underlying single telemetry end point.

NOTE: Tooltips on gauges have been implemented, but they have not for Scatter Plots.

Describe alternatives you've considered
Mobile support to also include a tap-and-hold gesture that displays a popup element that displays the full path.

Mo' Stuff
Here's a link to a Figma file that illustrates many of the examples: https://www.figma.com/proto/lqlMCzARTM3xl8WxbmuG6g/Path-to-Original-Tooltips-v1.0?page-id=0%3A1&type=design&node-id=1-94&viewport=357%2C176%2C0.51&scaling=scale-down&starting-point-node-id=1%3A94&show-proto-sidebar=1

@khalidadil khalidadil self-assigned this May 16, 2023
@khalidadil khalidadil linked a pull request Jun 23, 2023 that will close this issue
15 tasks
@unlikelyzero unlikelyzero added type:feature Feature. Required intentional design and removed severity:critical type:enhancement labels Jun 23, 2023
@unlikelyzero unlikelyzero added this to the Target:2.2.6 milestone Jun 23, 2023
charlesh88 added a commit that referenced this issue Jul 6, 2023
- Styling normalization, sanding and polishing.
@jvigliotta
Copy link
Contributor

jvigliotta commented Jul 18, 2023

Testathon - 7/18/23
Looks ... AWESOME!
I did find an issue where you can get the tooltip to stay up in the tree if you get the tooltip to popup then scroll in the tree, then I think you can only get it to go away if you trigger another tooltip

Another one: got this error hover over the value in gauges
Screenshot 2023-07-18 at 11 26 34 AM

@ozyx
Copy link
Member

ozyx commented Jul 18, 2023

Testathon - 7/18/23:

Need testing notes, but in general seems to work well-- not sure I've covered all scenarios.

There is an issue with pathing for VIPER plans (and I suspect any objects with non-default namespaces?)

@unlikelyzero
Copy link
Collaborator

Leaving open to track the three issues

@davetsay
Copy link
Contributor

Observed and filed #6810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature. Required intentional design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants