Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooltips] Add tooltips on hover #6756

Merged
merged 23 commits into from Jul 14, 2023
Merged

[Tooltips] Add tooltips on hover #6756

merged 23 commits into from Jul 14, 2023

Conversation

khalidadil
Copy link
Contributor

Closes #6656

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@khalidadil
Add tooltip api, extend object api to add telemetry composition looku…
90ee655 
…ps, and add tooltips to gauges/notebook embeds/plot legends/object frames/object names/time strips/recent objects/search results/object tree
@khalidadil
Merge branch 'release/2.2.5' into feature/issue-6656
37f5c1c
@khalidadil
Add tooltips to telemetry/lad tables
78c293b
@khalidadil
Clean up docs
b133fe4
@khalidadil khalidadil linked an issue Jun 23, 2023 that may be closed by this pull request
Show telemetry end point full path on hover #6656
Closed
@khalidadil khalidadil changed the title Feature/issue 6656 [Tooltips] Add tooltips Jun 23, 2023
@khalidadil khalidadil changed the title [Tooltips] Add tooltips [Tooltips] Add tooltips on hover Jun 23, 2023
@deploysentinel
Copy link

deploysentinel bot commented Jun 23, 2023 •
edited

Current Playwright Test Results Summary

✅ 13 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/14/2023 01:50:29am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: aa699cb

Started: 07/14/2023 01:48:53am UTC

View Detailed Build Results

Current Playwright Test Results Summary

✅ 133 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/14/2023 01:50:29am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: aa699cb

Started: 07/14/2023 01:38:37am UTC

⚠️ Flakes

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt
0.72% (1) 1 / 138 run
failed over last 7 days
78.99% (109) 109 / 138 runs
flaked over last 7 days

View Detailed Build Results

@khalidadil khalidadil requested a review from ozyx June 23, 2023 17:39
@codecov
Copy link

codecov bot commented Jun 23, 2023 •
edited

Codecov Report

Merging #6756 (aa699cb) into master (795d7a7) will increase coverage by 2.23%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master    #6756      +/-   ##
==========================================
+ Coverage   53.81%   56.04%   +2.23%     
==========================================
  Files         624      399     -225     
  Lines       24910    12159   -12751     
  Branches     2499        0    -2499     
==========================================
- Hits        13405     6815    -6590     
+ Misses      10832     5344    -5488     
+ Partials      673        0     -673
Flag Coverage Δ *Carryforward flag
e2e-full 42.16% <ø> (+<0.01%) ⬆️ Carriedforward from 6dfebb3
e2e-stable 53.41% <93.75%> (-1.73%) ⬇️
unit ?

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
openmct.js 100.00% <ø> (ø)
src/api/tooltips/tooltipMixins.js 86.95% <86.95%> (ø)
src/api/objects/ObjectAPI.js 91.20% <94.11%> (-2.27%) ⬇️
src/MCT.js 90.09% <100.00%> (-8.91%) ⬇️
src/api/tooltips/ToolTip.js 100.00% <100.00%> (ø)
src/api/tooltips/ToolTipAPI.js 100.00% <100.00%> (ø)

... and 394 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795d7a7...aa699cb. Read the comment docs.

@ozyx ozyx added this to the Target:2.2.6 milestone Jun 23, 2023
@charlesh88
Closes #6656
92b7f99 
- Styling normalization, sanding and polishing.
@charlesh88
Copy link
Contributor

Great stuff! I've pushed some tweaks to the CSS. As discussed, if we could add to Tabs views that'd be wonderful.

@unlikelyzero unlikelyzero added type:feature Feature. Required intentional design and removed severity:blocker labels Jul 7, 2023
@ozyx ozyx self-requested a review July 13, 2023 22:53
@khalidadil khalidadil marked this pull request as ready for review July 13, 2023 23:01
@khalidadil khalidadil enabled auto-merge (squash) July 13, 2023 23:21
@khalidadil khalidadil added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 13, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 13, 2023
@khalidadil khalidadil added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 13, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 14, 2023
ozyx
ozyx requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments. We should also make sure to document this feature somewhere, since it requires a hover + mod key, it may not be immediately discoverable.

src/api/objects/ObjectAPI.js Outdated Show resolved Hide resolved
src/plugins/conditionWidget/components/ConditionWidget.vue Show resolved Hide resolved
src/plugins/conditionWidget/components/ConditionWidget.vue Show resolved Hide resolved
src/api/tooltips/ToolTipAPI.js Outdated Show resolved Hide resolved
src/api/tooltips/ToolTipAPI.js Outdated Show resolved Hide resolved
src/api/tooltips/tooltipMixins.js Outdated Show resolved Hide resolved
src/styles/_controls.scss Show resolved Hide resolved
@khalidadil
Copy link
Contributor Author

Just a few minor comments. We should also make sure to document this feature somewhere, since it requires a hover + mod key, it may not be immediately discoverable.

I'll ask Charles where the best place to document this would be and include it when I add more tests

@khalidadil khalidadil requested a review from ozyx July 14, 2023 01:38
@khalidadil khalidadil added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 14, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 14, 2023
ozyx
ozyx approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🚀🚀

@khalidadil khalidadil merged commit cde8fbb into master Jul 14, 2023
17 of 18 checks passed
@khalidadil khalidadil deleted the feature/issue-6656 branch July 14, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozyx ozyx ozyx approved these changes

Assignees
No one assigned
Labels
type:feature Feature. Required intentional design
Projects
None yet
Milestone
Target:3.0.0
Development

Successfully merging this pull request may close these issues.

Show telemetry end point full path on hover
5 participants
@khalidadil @charlesh88 @ozyx @akhenry @unlikelyzero