Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console error when navigating away from a LADTableSet #6854

Closed
7 tasks
ozyx opened this issue Jul 28, 2023 · 3 comments · Fixed by #6855
Closed
7 tasks

Console error when navigating away from a LADTableSet #6854

ozyx opened this issue Jul 28, 2023 · 3 comments · Fixed by #6855
Assignees
@ozyx
Labels
type:bug
Milestone
Target:3.0.0

Comments

@ozyx
Copy link
Member

ozyx commented Jul 28, 2023 •
edited

Summary

On nav away from a LADTableSet, console errors are thrown while unregistering composition listeners.

Expected vs Current Behavior

No console errors should happen

Steps to Reproduce

  1. Create a couple LAD tables
  2. Create a LAD Table Set and add the LAD tables to it
  3. Navigate to it
  4. Navigate away, observe console errors

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

image
@ozyx ozyx added the type:bug label Jul 28, 2023
@ozyx ozyx added this to the Target:3.0.0 milestone Jul 28, 2023
@ozyx ozyx self-assigned this Jul 28, 2023
@ozyx ozyx mentioned this issue Jul 28, 2023
Merged
15 tasks
@ozyx
Copy link
Member Author

ozyx commented Jul 28, 2023

Testing Instructions

  1. Follow reproduction steps above and verify that no console errors are thrown on nav away

jvigliotta pushed a commit that referenced this issue Jul 28, 2023
@ozyx
fix(#6854): [LADTableSet] prevent compositions from becoming reactive (…
194eb43 
…#6855)

* fix: prevent compositions from becoming reactive
@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 07/31/23

@charlesh88
Copy link
Contributor

Testathon 2023-07-31: verified fixed.

@ozyx ozyx removed the unverified label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozyx ozyx

Labels
type:bug
Projects
None yet
Milestone
Target:3.0.0
Development

Successfully merging a pull request may close this issue.

fix(#6854): [LADTableSet] prevent compositions from becoming reactive nasa/openmct
4 participants
@charlesh88 @khalidadil @akhenry @ozyx