Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#6854): [LADTableSet] prevent compositions from becoming reactive #6855

Merged
merged 2 commits into from Jul 28, 2023

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Jul 28, 2023

Closes #6854

Describe your changes:

Declare and initialize this.compositions in the created() hook rather than data() so that objects added to it do not become reactive, and thus can access their own private class methods.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:3.0.0 milestone Jul 28, 2023
@ozyx ozyx requested a review from jvigliotta July 28, 2023 18:57
@ozyx ozyx changed the title fix(#6821): prevent compositions from becoming reactive fix(#6821): [LadTableSet] prevent compositions from becoming reactive Jul 28, 2023
@ozyx ozyx changed the title fix(#6821): [LadTableSet] prevent compositions from becoming reactive fix(#6821): [LADTableSet] prevent compositions from becoming reactive Jul 28, 2023
@ozyx ozyx changed the title fix(#6821): [LADTableSet] prevent compositions from becoming reactive fix(#6854): [LADTableSet] prevent compositions from becoming reactive Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #6855 (6f48efa) into master (3c2b032) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6855      +/-   ##
==========================================
+ Coverage   48.16%   48.19%   +0.02%     
==========================================
  Files         643      643              
  Lines       25618    25619       +1     
  Branches     2507     2507              
==========================================
+ Hits        12340    12347       +7     
+ Misses      12801    12795       -6     
  Partials      477      477              
Flag Coverage Δ *Carryforward flag
e2e-full 41.97% <ø> (ø) Carriedforward from 349b909
e2e-stable 56.83% <ø> (+0.67%) ⬆️
unit 38.72% <0.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/plugins/LADTable/components/LadTableSet.vue 45.54% <0.00%> (+0.54%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c2b032...6f48efa. Read the comment docs.

@deploysentinel
Copy link

deploysentinel bot commented Jul 28, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/28/2023 07:18:34pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 6f48efa

Started: 07/28/2023 07:16:38pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 131 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/28/2023 07:18:34pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 6f48efa

Started: 07/28/2023 07:11:14pm UTC

⚠️ Flakes

📄   functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 2Retry 1Initial Attempt
12.07% (7) 7 / 58 runs
failed over last 7 days
29.31% (17) 17 / 58 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good catch!

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 28, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 28, 2023
@jvigliotta jvigliotta merged commit 194eb43 into master Jul 28, 2023
12 checks passed
@jvigliotta jvigliotta deleted the mct6821 branch July 28, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console error when navigating away from a LADTableSet
2 participants