Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Add security guide #1900

Merged
merged 7 commits into from
Feb 2, 2018
Merged

[Documentation] Add security guide #1900

merged 7 commits into from
Feb 2, 2018

Conversation

VWoeltjen
Copy link
Contributor

Add a security guide to address #1833. Handled this as a separate document, rephrasing the concerns identified in that document for an audience of plugin developers and system administrators.

Copy link
Contributor

@psarram psarram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good guide. One question, is it worth mentioning that we also run JSLint which checks for some security vulnerabilities?

@VWoeltjen
Copy link
Contributor Author

Author Checklist

  1. Changes address original issue? Y
  2. Unit tests included and/or updated with changes? N/A (documentation only)
  3. Command line build passes? Y
  4. Changes have been smoke-tested? Y

@psarram
Copy link
Contributor

psarram commented Feb 2, 2018

Reviewer Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? N/A
  3. Code style and in-line documentation are appropriate? N/A
  4. Commit messages meet standards? Y

@psarram psarram merged commit 5d3adc6 into master Feb 2, 2018
@psarram psarram deleted the deployment-guide-1833 branch February 2, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants