Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In local clock mode, if we're panning or zooming, don't purge older records #3996

Merged
merged 2 commits into from
Jul 7, 2021
Merged

In local clock mode, if we're panning or zooming, don't purge older records #3996

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0a3d20
In local clock mode, if we're panning or zooming, don't purge older r…
shefalijoshi Jul 7, 2021
2ec0e3c
Refactor conditions
shefalijoshi Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/plugins/plot/MctPlot.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,9 +427,11 @@ export default {
this.skipReloadOnInteraction = false;
this.loadMoreData(newRange, true);
} else {
// If we're not panning or zooming (time conductor and plot x-axis times are not out of sync)
// Drop any data that is more than 1x (max-min) before min.
// Limit these purges to once a second.
if (!this.nextPurge || this.nextPurge < Date.now()) {
if (!this.isTimeOutOfSync
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can declare variables for this and remove comments? something like

const isPanningOrZooming = this.isTimeOutOfSync;
const isPurgeData = !isPanningOrZooming && (!this.nextPurge || this.nextPurge < Date.now()));
if (isPurgeData) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SURE!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

&& (!this.nextPurge || this.nextPurge < Date.now())) {
const keepRange = {
min: newRange.min - (newRange.max - newRange.min),
max: newRange.max
Expand Down