Timelist views support fixed time - 5629 #5726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/2.1.0 #5726 +/- ##
================================================
Coverage ? 53.76%
================================================
Files ? 597
Lines ? 22481
Branches ? 2070
================================================
Hits ? 12086
Misses ? 9818
Partials ? 577
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report at Codecov.
|
michaelrogers
changed the title
shefalijoshi
requested changes
Sep 9, 2022
michaelrogers
force-pushed
the
mct5629-v2
branch
from
deebdcf
to
df0489a
Compare
Set timestamp to clock start when in fixed time
shefalijoshi
approved these changes
Sep 15, 2022
ozyx
pushed a commit
that referenced
this pull request
Sep 19, 2022
* Update version * [Flexible Layout] Fix draggable status for layout items while in browse mode (#5750) * Modify flexible layout pages to make them not draggable in browse mode and add e2e test * Don't destroy mutable if the domain object is not ready yet (#5695) * Check if the domain object is set (mounted is done) before trying to destroy the mutable * Use optional chaining. Add mutable promise check to prevent memory leaks * Request priority (#5737) * Set priority of couch requests to high * Set priority of image requests to low * Add e2e test for low-priority images * Timelist views support fixed time - 5629 (#5726) * Initialize full view for fixed time * Clean up * Add back in ticker after merge * Check for undefined clock instead of timestamp * Cleanup * Initialize full view for fixed time * Clean up * Add back in ticker after merge * Check for undefined clock instead of timestamp * Cleanup * Update timestamp method and remove from beforeDestroy * Shorten ternary to optional chaining * Cleanup unused var * Moved duplicated logic to method * Reorder methods * Update Timelist.vue Set timestamp to clock start when in fixed time * Added blank line * Lint fix * Update pluginSpec.js * Invoke currentValue method properly Co-authored-by: Khalid Adil <khalidadil29@gmail.com> Co-authored-by: Andrew Henry <akhenry@gmail.com> Co-authored-by: Michael Rogers <contact@mhrogers.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5629
Describe your changes:
All events are shown in a timelist view whenever a non-realtime mode is selected. Changes cherry picked from the previous PR that targeted the release branch.
All Submissions:
Author Checklist
Reviewer Checklist