2.1.0 backmerge into master #5784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se mode (#5750) * Modify flexible layout pages to make them not draggable in browse mode and add e2e test
* Check if the domain object is set (mounted is done) before trying to destroy the mutable * Use optional chaining. Add mutable promise check to prevent memory leaks
* Set priority of couch requests to high * Set priority of image requests to low * Add e2e test for low-priority images
* Initialize full view for fixed time * Clean up * Add back in ticker after merge * Check for undefined clock instead of timestamp * Cleanup * Initialize full view for fixed time * Clean up * Add back in ticker after merge * Check for undefined clock instead of timestamp * Cleanup * Update timestamp method and remove from beforeDestroy * Shorten ternary to optional chaining * Cleanup unused var * Moved duplicated logic to method * Reorder methods * Update Timelist.vue Set timestamp to clock start when in fixed time * Added blank line * Lint fix * Update pluginSpec.js * Invoke currentValue method properly
shefalijoshi
requested review from
unlikelyzero and
ozyx
and removed request for
unlikelyzero
Codecov Report
@@ Coverage Diff @@
## master #5784 +/- ##
==========================================
- Coverage 54.52% 53.99% -0.54%
==========================================
Files 597 597
Lines 22529 22604 +75
Branches 2065 2071 +6
==========================================
- Hits 12285 12206 -79
- Misses 9668 9817 +149
- Partials 576 581 +5
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Merging 2.1.0 back into master
All Submissions:
Author Checklist
Reviewer Checklist