Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTEMS OS_GetTaskId_Impl returns invalid value from root task #1084

Closed
jphickey opened this issue Jun 25, 2021 · 0 comments · Fixed by #1085 or #1098
Closed

RTEMS OS_GetTaskId_Impl returns invalid value from root task #1084

jphickey opened this issue Jun 25, 2021 · 0 comments · Fixed by #1085 or #1098
Assignees
@jphickey
Labels
bug RTEMS unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Describe the bug
The "root" or initial task is technically not an OSAL task and does not have an OSAL ID. If OSAL OS_GetTaskId() is called, it should return OS_OBJECT_ID_UNDEFINED. However on RTEMS it returns a nonzero value which is not a valid task ID.

To Reproduce
Run unit tests on RTEMS

Expected behavior
OS_GetTaskId() should return OS_OBJECT_ID_INVALID if the "rtems classic name" is not actually an OSAL task ID.

System observed on:
RTEMS 4.11.3

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jun 25, 2021
@jphickey jphickey added the bug label Jun 25, 2021
jphickey added a commit to jphickey/osal that referenced this issue Jun 25, 2021
@jphickey
Fix nasa#1084, root task ID on RTEMS
91f400c 
Ensures that OS_GetTaskId_Impl() returns OS_OBJECT_ID_UNDEFINED
if called from the root task - as this does not have an OSAL task ID.
jphickey added a commit to jphickey/osal that referenced this issue Jun 25, 2021
@jphickey
Fix nasa#1084, root task ID on RTEMS
5f4ff98 
Ensures that OS_GetTaskId_Impl() returns OS_OBJECT_ID_UNDEFINED
if called from the root task - as this does not have an OSAL task ID.
@jphickey jphickey mentioned this issue Jun 25, 2021
Merged
@jphickey jphickey added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Jun 25, 2021
@skliper skliper added this to the 6.0.0 milestone Jun 28, 2021
astrogeco added a commit that referenced this issue Jul 2, 2021
@astrogeco
Merge pull request #1085 from jphickey/fix-1084-rtems-root-taskid
a3801ab 
Fix #1084, root task ID on RTEMS
@astrogeco astrogeco mentioned this issue Jul 2, 2021
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1084 from skliper/fix877-one_missionrev_2_rul…
5b1d054 
…e_them_all

Fix nasa#877, Remove duplicate CFE_MISSION_REV define
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug RTEMS unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #1084, root task ID on RTEMS jphickey/osal
osal Integration candidate: 2021-06-29 nasa/osal
3 participants
@jphickey @skliper @astrogeco