Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS_FS_GetPhysDriveName should take a buffer size #877

Open
skliper opened this issue Mar 10, 2021 · 0 comments
Open

OS_FS_GetPhysDriveName should take a buffer size #877

skliper opened this issue Mar 10, 2021 · 0 comments
Labels
CFS-38 enhancement

Comments

@skliper
Copy link
Contributor

skliper commented Mar 10, 2021

Is your feature request related to a problem? Please describe.
OS_FS_GetPhysDriveName assumes buffer size:

osal/src/os/shared/src/osapi-filesys.c

Lines 631 to 632 in ead5723

strncpy(PhysDriveName, filesys->system_mountpt, OS_FS_PHYS_NAME_LEN - 1);
PhysDriveName[OS_FS_PHYS_NAME_LEN - 1] = 0;

Describe the solution you'd like
Update/replace with API that takes buffer size

Describe alternatives you've considered
Leave as-is (future work)

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#877, Remove duplicate CFE_MISSION_REV define
1b31bd9
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1084 from skliper/fix877-one_missionrev_2_rul…
5b1d054 
…e_them_all

Fix nasa#877, Remove duplicate CFE_MISSION_REV define
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-38 enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skliper