Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1110, Modify unreachable branch in OS_ObjectIdAllocateNew #1327

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix #1110, Modify unreachable branch in OS_ObjectIdAllocateNew #1327

merged 1 commit into from
Feb 27, 2023

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Nov 8, 2022 •
edited
Loading

Checklist

Describe the contribution
Fixes #1110
Changes 2 mutually exclusive, consecutive if statements to an if/else block.
I believe this is the most parsimonious fix to this issue.

Testing performed
GitHub CI Unit Tests all passing successfully.

Expected behavior changes
No change to behavior.

Contributor Info
Avi @thnkslprpt

@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
@dzbaker dzbaker requested a review from chillfig February 9, 2023 19:19
chillfig
chillfig approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I also tested the change locally (Ubuntu 20.04), it increases branch coverage to 100% in osapi-idmap.c

@dzbaker dzbaker added the CCB:Approved Indicates code review and approval by community CCB label Feb 23, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Feb 27, 2023
@dzbaker
IC: Caelum-rc4+dev39
5453ac0 
*Combines:*

osal v6.0.0-rc4+dev199
tblCRCTool v1.3.0-rc4+dev28

**Includes:**

*osal*
- nasa/osal#1327

*tblCRCTool*
- nasa/tblCRCTool#77

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
This was referenced Feb 27, 2023
Merged
Merged
@dzbaker dzbaker merged commit 715b6c4 into nasa:main Feb 27, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Feb 27, 2023
@dzbaker
IC: Caelum-rc4+dev40
967bb7d 
*Combines:*

osal v6.0.0-rc4+dev199
tblCRCTool v1.3.0-rc4+dev28

**Includes:**

*osal*
- nasa/osal#1327

*tblCRCTool*
- nasa/tblCRCTool#77

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
@thnkslprpt thnkslprpt deleted the fix-1110-modify-unreachable-branch-in-OS_ObjectIdAllocateNew branch February 27, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chillfig chillfig chillfig approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Equuleus
Development

Successfully merging this pull request may close these issues.

Unreachable error branch in OS_ObjectIdAllocateNew
3 participants
@thnkslprpt @chillfig @dzbaker