Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1417, Fix #1418, Fix workflow bug and enforce updating of coverage minimums #1419

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

  • Fixes Subtle bug in Code Coverage CI workflow #1418
    • Removes this bug by adding a condition to the coverage check workflows to only run in debug builds (by checking for env.run_lcov == 'TRUE', which is what triggers the 'Check Coverage' step to run)
    • Also removed the condition to only run the coverage workflows in the ubuntu-20.04 debug build - now it will run fully in both the 20.04 and 22.04 debug builds. Happy to change this back if there is some specific reason to limit these checks to only 20.04.
  • Fixes Enforce keeping coverage minimums up-to-date in Code Coverage CI workflow #1417
    • Adds additional steps in the code coverage workflow to check that the missed functions/lines/branches variables are kept up to date.

Testing performed
Tested all variations of coverage thresholds (above, below, split between functions/lines/branches etc.) to confirm expected behavior.

New checks:
Screenshot 2023-09-23 20 32 15

Expected behavior changes
Any PR that improves coverage will cause the workflow to fail now unless the allowed_ncov_lines, allowed_ncov_branches and/or allowed_ncov_functions variables are updated as part of the same PR.

System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-1417-and-1418-coverage-workflow-bug-fix-and-enforce-updating branch from d449b9c to 2fba676 Compare March 23, 2024 11:16
@dzbaker dzbaker self-assigned this May 2, 2024
@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Aug 8, 2024
@thnkslprpt thnkslprpt force-pushed the fix-1417-and-1418-coverage-workflow-bug-fix-and-enforce-updating branch from 2fba676 to 471a3a4 Compare August 8, 2024 17:42
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Aug 8, 2024
@thnkslprpt thnkslprpt force-pushed the fix-1417-and-1418-coverage-workflow-bug-fix-and-enforce-updating branch from d99bff7 to d95c5f6 Compare August 8, 2024 18:45
@thnkslprpt
Copy link
Contributor Author

FYI @dzbaker I rebased this to main and updated it to make the plural/singular wording automatic.

image

@dzbaker
Copy link
Collaborator

dzbaker commented Aug 8, 2024

FYI @dzbaker I rebased this to main and updated it to make the plural/singular wording automatic.

image

Thanks!

dzbaker added a commit to nasa/cFS that referenced this pull request Aug 16, 2024
*Combines:*

cFE equuleus-rc1+dev187
osal equuleus-rc1+dev85
PSP equuleus-rc1+dev48

**Includes:**

*cFE*
- nasa/cFE#2591

*osal*
- nasa/osal#1419

*PSP*
- nasa/PSP#436

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Jose Martinez Pedraza <pepepr08@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker added a commit to nasa/cFS that referenced this pull request Aug 22, 2024
*Combines:*

cFE equuleus-rc1+dev187
osal equuleus-rc1+dev85

**Includes:**

*cFE*
- nasa/cFE#2591

*osal*
- nasa/osal#1419

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Jose Martinez Pedraza <pepepr08@users.noreply.github.com>
@dzbaker dzbaker merged commit 60eed33 into nasa:main Aug 22, 2024
19 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Aug 22, 2024
*Combines:*

cFE equuleus-rc1+dev187
osal equuleus-rc1+dev85

**Includes:**

*cFE*
- nasa/cFE#2591

*osal*
- nasa/osal#1419

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Jose Martinez Pedraza <pepepr08@users.noreply.github.com>
@thnkslprpt thnkslprpt deleted the fix-1417-and-1418-coverage-workflow-bug-fix-and-enforce-updating branch August 23, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
3 participants