Fix #692, fix or statements

[zanzaben]

Describe the contribution
Fixes #692
fixed the or statement to correctly compare against both options.

Testing performed
Build and run unit test

Expected behavior changes
will correctly cath failures when they happen

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

[skliper]

How about" Fix #692, Resolve typos in unit test assert OR statements"?

[skliper]

Looking closer I'd recommend something like:

if (actual == OS_ERR_NOT_IMPLEMENTED)
{
    UtPrintf("XXX API not implemented");
}
else
{
... do rest of the test
}

[skliper]

Needs auto-formatting applied, otherwise great improvement.

[skliper]

Side note - not implemented isn't actually considered and "error", test passes either way (and it's OK for OSAL/OS's to not implement all API functionality).

[zanzaben]

Side note - not implemented isn't actually considered and "error", test passes either way (and it's OK for OSAL/OS's to not implement all API functionality).

Well then it shouldn't be called os_ERR_not_implemented

[skliper]

Good point! In the context of FSW it is an error, and brings up that we should probably be flagging the not implemented cases as UTASSERT_CASETYPE_NA so they get explicitly counted/reported. Lets address that as a separate issue though.

[astrogeco]

CCB 2021-01-13 APPROVED

@skliper opened related issue to make finding "not implemented" items