osal Integration candidate: 2021-01-19 #767

astrogeco · 2021-01-21T15:31:38Z

Describe the contribution

Fix #746, Add UtDebug message from OS_printf stub
Fix #692, Resolve typos in unit test assert OR statements
Fix #577, Document nested tests not supported
Fix #753, Remove UT_CheckForOpenSockets
Fix #229, add mqueue functional test
Fix #757, Readd extern C in osapi.h to support C++ use
Fix #692, display message when not implemented error occurs
Fix #591, add test teardown failure to test summary
Fix #699, format printf correctly
Fix #685, change file create to use read write
Fix #748, add additional casts
Fix #743, Create Security Policy
Fix #429, update OS_time_t definition to 64 ticks
Fix #718, deprecate OS_fsBlocksFree and OS_fsBytesFree
Fix #761, Terminate string in TestReadWriteLseek
Fix #724, Refactor UT_ClearForceFail to UT_ClearDefaultReturnValue
Fix #722, update UT_SetDefaultReturnValue comments
Fix #229, mqueue test uses sequence of numbers
Fix #760, Install modules and clean up files for unit tests

Testing performed
See https://github.com/nasa/cFS/pull/177/checks

Expected behavior changes

PR #748

PR #759

PR #696

PR #747

PR #751

PR #763

PR #758

PR #725

PR #694

PR #754

PR #749

PR #739

PR #695

PR #735

PR #764

System(s) tested on
Ubuntu 18.04

Additional context
Part of nasa/cFS#177

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@zanzaben
@skliper
@ArielSAdamsNASA

Use a single 64-bit tick counter as OS_time_t, rather than a split 32 bit seconds + 32 bit microseconds counter. This benefits in several ways: - increases the timing precision by 10x (0.1us ticks) - increases the representable range by 400x (+/-14000 yrs) - simplifies addition/subtraction (no carry over) - avoids "year 2038" bug w/32-bit timestamps

Users should call OS_FileSysStatVolume() and read the respective output members of the structure as indicated.

Fix #699, format printf correctly

Fix #718, deprecate OS_fsBlocksFree and OS_fsBytesFree

Fix #743, Create OSAL Security Policy Markdown

Fix #746, Add UtDebug message from OS_printf stub

Fix #577, Document nested tests not supported

astrogeco · 2021-01-21T15:43:02Z

@skliper,

Got a segfault after adding #747

81/81 Test #81: sample_lib-sample_lib .............***Exception: SegFault  0.10 sec

96% tests passed, 3 tests failed out of 81

Total Test time (real) = 143.67 sec

The following tests FAILED:
	 69 - cfe-core_es_UT (Failed)
Errors while running CTest
	 71 - cfe-core_evs_UT (SEGFAULT)
	 81 - sample_lib-sample_lib (SEGFAULT)
Makefile:138: recipe for target 'test' failed
make: *** [test] Error 8
Error: Process completed with exit code 2.

See https://github.com/nasa/cFS/pull/177/checks?check_run_id=1742875628

Fix #761, Terminate string in TestReadWriteLseek

Fix #757, Read extern C in osapi.h to support C++ use

Fix #724, #722, rename ut clear force fail

Fix #591, add test teardown failure to test summary

Fix #753, Remove UT_CheckForOpenSockets

Fix #685 change file create to use read write

…ertions Fix #692, fix or statements

Fix #229, mqueue functional test

Fix #429, OS_time_t with single tick counter

Fix #760, Install modules and clean up files for unit tests

Update ReadMe

Combines: nasa/cFE#1109 nasa/osal#767 nasa/PSP#243 nasa/sample_app#121 nasa/ci_lab#68 nasa/to_lab#79 nasa/sch_lab#62 nasa/sample_lib#41 nasa/tblCRCTool#29 nasa/elf2cfetbl#65 nasa/cFS-GroundSystem#150

skliper and others added 20 commits January 7, 2021 15:30

Fix #746, Add UtDebug message from OS_printf stub

5bbf041

Fix #692, Resolve typos in unit test assert OR statements

4b65be0

Fix #577, Document nested tests not supported

62eb12d

Fix #753, Remove UT_CheckForOpenSockets

c968de0

Fix #229, add mqueue functional test

e963847

Fix #757, Readd extern C in osapi.h to support C++ use

df458a3

Fix #692, display message when not implemented error occurs

a928734

Fix #591, add test teardown failure to test summary

55aa1a7

Fix #699, format printf correctly

b0cb76e

Fix #685, change file create to use read write

9074cf9

Fix #748, add additional casts

0d4c3c7

Fix #743, Create Security Policy

619e88f

Fix #718, deprecate OS_fsBlocksFree and OS_fsBytesFree

8c7535c

Users should call OS_FileSysStatVolume() and read the respective output members of the structure as indicated.

Fix #761, Terminate string in TestReadWriteLseek

08693cc

Merge pull request #748 from zanzaben/fix699_Select_Test_RTEMS

2b1211a

Fix #699, format printf correctly

Merge pull request #759 from jphickey/fix-718-deprecate-bytesblocksfree

ff42bfd

Fix #718, deprecate OS_fsBlocksFree and OS_fsBytesFree

Merge pull request #696 from ArielSAdamsNASA/SecurityPolicy

e453e2f

Fix #743, Create OSAL Security Policy Markdown

Merge pull request #747 from skliper/fix746-os_printf_stub_print

709b582

Fix #746, Add UtDebug message from OS_printf stub

Merge pull request #751 from skliper/fix577-nested_add

86b13a2

Fix #577, Document nested tests not supported

astrogeco added the IC:2021-01-19 label Jan 21, 2021

skliper and others added 8 commits January 21, 2021 11:41

HOTFIX - Reset va list in OS_printf stub

33738d0

Merge pull request #763 from skliper/fix761-ut_file_null

0af2a55

Fix #761, Terminate string in TestReadWriteLseek

Merge pull request #758 from skliper/fix757-cpp_typo

0d569e4

Fix #757, Read extern C in osapi.h to support C++ use

Fix #724, Refactor UT_ClearForceFail to UT_ClearDefaultReturnValue

3fa2f50

Fix #722, update UT_SetDefaultReturnValue comments

e248041

Merge pull request #725 from zanzaben/fix724_Rename_UT_ClearForceFail

436e1ea

Fix #724, #722, rename ut clear force fail

Fix #229, mqueue test uses sequence of numbers

f725ee4

Merge pull request #694 from zanzaben/fix591_TTF_not_reported

4165e67

Fix #591, add test teardown failure to test summary

astrogeco and others added 7 commits January 24, 2021 21:11

Merge pull request #754 from skliper/fix753-rm_ut_checkforopensockets

95cab23

Fix #753, Remove UT_CheckForOpenSockets

Merge pull request #749 from zanzaben/fix685_RTEMS_chmod_test

0ba7e87

Fix #685 change file create to use read write

Merge pull request #739 from zanzaben/fix692_network_api_state_or_ass…

4a87c68

…ertions Fix #692, fix or statements

Merge pull request #695 from zanzaben/fix229_mqueue_functional_test

bddede2

Fix #229, mqueue functional test

Merge pull request #735 from jphickey/fix-429-expand-ostimet-part2

0867182

Fix #429, OS_time_t with single tick counter

Fix #760, Install modules and clean up files for unit tests

773dc88

Merge pull request #764 from skliper/fix760-ut_fails

6af008c

Fix #760, Install modules and clean up files for unit tests

astrogeco mentioned this pull request Jan 25, 2021

cFS Bundle Integration candidate: 2021-01-19 nasa/cFS#177

Merged

Bump to v5.1.0-rc1+dev221

27d99a2

Update ReadMe

astrogeco marked this pull request as ready for review January 27, 2021 00:34

astrogeco merged commit 09a2c5e into main Jan 27, 2021

astrogeco added a commit to nasa/cFS that referenced this pull request Feb 3, 2021

Add nasa/osal#767

9431a72

skliper added this to the 6.0.0 milestone Sep 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

osal Integration candidate: 2021-01-19 #767

osal Integration candidate: 2021-01-19 #767

astrogeco commented Jan 21, 2021 •

edited

Loading

astrogeco commented Jan 21, 2021

osal Integration candidate: 2021-01-19 #767

osal Integration candidate: 2021-01-19 #767

Conversation

astrogeco commented Jan 21, 2021 • edited Loading

astrogeco commented Jan 21, 2021

astrogeco commented Jan 21, 2021 •

edited

Loading