-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect assertions in network-api-test #692
Milestone
Comments
skliper
added
the
unit-test
Tickets related to the OSAL unit testing (functional and/or coverage)
label
Jan 4, 2021
zanzaben
added a commit
to zanzaben/osal
that referenced
this issue
Jan 5, 2021
zanzaben
added a commit
to zanzaben/osal
that referenced
this issue
Jan 11, 2021
zanzaben
added a commit
to zanzaben/osal
that referenced
this issue
Jan 11, 2021
zanzaben
added a commit
to zanzaben/osal
that referenced
this issue
Jan 11, 2021
zanzaben
added a commit
to zanzaben/osal
that referenced
this issue
Jan 11, 2021
zanzaben
added a commit
to zanzaben/osal
that referenced
this issue
Jan 13, 2021
astrogeco
added a commit
that referenced
this issue
Jan 25, 2021
…ertions Fix #692, fix or statements
jphickey
pushed a commit
to jphickey/osal
that referenced
this issue
Aug 10, 2022
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The test is not correctly checking the return value in a few places. For example:
osal/src/tests/network-api-test/network-api-test.c
Line 129 in 9407cdf
osal/src/tests/network-api-test/network-api-test.c
Line 133 in 9407cdf
To Reproduce
Make the subject code return something other than OS_SUCCESS or OS_ERR_NOT_IMPLEMENTED. Assert statement will still be true.
Expected behavior
Probably should be
actual == OS_SUCCESS || actual == OS_ERR_NOT_IMPLEMENTED
System observed on:
N/A - inspection
Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: