Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect assertions in network-api-test #692

Closed
jphickey opened this issue Dec 15, 2020 · 0 comments · Fixed by #739 or #767
Closed

Incorrect assertions in network-api-test #692

jphickey opened this issue Dec 15, 2020 · 0 comments · Fixed by #739 or #767
Assignees
Labels
bug unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone

Comments

@jphickey
Copy link
Contributor

Describe the bug
The test is not correctly checking the return value in a few places. For example:

UtAssert_True(actual == OS_SUCCESS || OS_ERR_NOT_IMPLEMENTED, "OS_SocketAddrInit() (%ld) == OS_SUCCESS",

UtAssert_True(actual == OS_INVALID_POINTER || OS_ERR_NOT_IMPLEMENTED,

To Reproduce
Make the subject code return something other than OS_SUCCESS or OS_ERR_NOT_IMPLEMENTED. Assert statement will still be true.

Expected behavior
Probably should be actual == OS_SUCCESS || actual == OS_ERR_NOT_IMPLEMENTED

System observed on:
N/A - inspection

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the bug label Dec 15, 2020
@skliper skliper added this to the 6.0.0 milestone Jan 4, 2021
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Jan 4, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 5, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 11, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 11, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 11, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 11, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 13, 2021
astrogeco added a commit that referenced this issue Jan 25, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants