Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #699, format printf correctly #748

Merged

Conversation

zanzaben
Copy link
Contributor

@zanzaben zanzaben commented Jan 11, 2021

Describe the contribution
Fixes #699
Fixed the formatting to correctly build. Have been unable to test on RTEMS 4

Testing performed
Tested on RTEMS 5 and worked.

Expected behavior changes
Able to build

System(s) tested on
Ubuntu 20.04 RTEMS 5

Additional context
Needs to be tested on RTEMS 4

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@zanzaben zanzaben marked this pull request as draft January 11, 2021 15:30
@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jan 11, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Jan 13, 2021

CCB 2021-01-13 APPROVED

@jphickey will test on RTEMS 4

@astrogeco astrogeco added CCB:2021-01-13 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jan 13, 2021
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still had some errors when compiling in RTEMS 4.11 - 3 more conversions needed to be updated. I just pushed commit 0d4c3c7 to fix. It works now.

@skliper skliper changed the title WIP Fix #699 format printf correctly Fix #699 format printf correctly Jan 14, 2021
@skliper skliper marked this pull request as ready for review January 14, 2021 20:46
@astrogeco astrogeco changed the title Fix #699 format printf correctly Fix #699, format printf correctly Jan 21, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate January 21, 2021 14:34
@astrogeco astrogeco merged commit 2b1211a into nasa:integration-candidate Jan 21, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 21, 2021
@zanzaben zanzaben deleted the fix699_Select_Test_RTEMS branch April 2, 2021 14:10
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build broken on RTEMS 4.11
4 participants