Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search on revision_date #67

Closed
frankinspace opened this issue Jul 22, 2024 · 3 comments · Fixed by #68
Closed

Search on revision_date #67

frankinspace opened this issue Jul 22, 2024 · 3 comments · Fixed by #68
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@frankinspace
Copy link
Collaborator

frankinspace commented Jul 22, 2024

Add option to search for granules by revision_date.

  • Add revision_date function to Query class (need to verify revision_date is not specific to only some concepts, I think it applies to all CMR concepts)
  • Add test to verify documents are included/excluded based on their revision_date
  • Add example usage to README
  • Update CHANGELOG
@frankinspace frankinspace added enhancement New feature or request good first issue Good for newcomers labels Jul 22, 2024
@nikki-t
Copy link
Contributor

nikki-t commented Jul 23, 2024

@frankinspace - I think it may make sense to place the revision_date function in the GranuleCollectionBaseQuery class as the revision_date query parameter can be used for both Collection and Granule based searches but not for Services, Tools, or Variables.

If we place the function in the Query class which gets inherited by the Tool, Service, and Variable classes then we are creating a function in the parent class that can't really be used by the child classes. Does that seem right? (At least this is my understanding based off the CMR API documentation)

@chuckwondo
Copy link
Collaborator

@frankinspace - I think it may make sense to place the revision_date function in the GranuleCollectionBaseQuery class as the revision_date query parameter can be used for both Collection and Granule based searches but not for Services, Tools, or Variables.

If we place the function in the Query class which gets inherited by the Tool, Service, and Variable classes then we are creating a function in the parent class that can't really be used by the child classes. Does that seem right? (At least this is my understanding based off the CMR API documentation)

Yes, that's right.

@frankinspace
Copy link
Collaborator Author

Thanks for confirming, yes I wasn't sure what 'level' it would apply to in the original description. Sounds like GranuleCollectionBaseQuery is appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants