Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification dropdown #1152

Merged
merged 24 commits into from
Nov 5, 2015
Merged

Notification dropdown #1152

merged 24 commits into from
Nov 5, 2015

Conversation

UnspeakableHorror
Copy link
Collaborator

Closes #622.

Added notifications for the following actions:

  • Posting comments on someone's resume.
  • Requesting feedback from an existing user, the user will get a notification informing him of this plus the usual email.
  • Requesting to add an existing user as Personal Reference.

Api docs:

  • Swagger-ui.
  • notifications.md
  • reference-request.md

Check and uncomment notifications in /documents/src/main/resources/documents/db/h2/migration/V11__change_user_notification.sql to test.

Other:

  • Removed hardcoded sectionVersion for new comments, it was defaulting to 1 rather than using the version from the section which caused posting new comments on new sections to fail.
  • Fixed a bug where tests would use users from different context causing some tests to fail.

@UnspeakableHorror UnspeakableHorror self-assigned this Oct 28, 2015
@UnspeakableHorror UnspeakableHorror added this to the 2015-10-30 milestone Oct 28, 2015
@natebenson natebenson deployed to vyllage-pr-1152 October 28, 2015 03:49 Active
@natebenson natebenson deployed to vyllage-pr-1152 October 28, 2015 04:14 Active
@natebenson natebenson deployed to vyllage-pr-1152 October 28, 2015 04:28 Active
@tylerbenson
Copy link
Owner

I don't think this should close 622, since it's likely just the backend work, right?

@UnspeakableHorror
Copy link
Collaborator Author

No, but we can open it again.

@UnspeakableHorror UnspeakableHorror mentioned this pull request Oct 30, 2015
Open
@UnspeakableHorror
Copy link
Collaborator Author

For some reason a single access check test is failing on the CIs, it runs fine locally. Once I'm done adding all the remaining tests I'll check what's wrong with it.

@natebenson natebenson deployed to vyllage-pr-1152 November 3, 2015 07:18 Active
@natebenson natebenson deployed to vyllage-pr-1152 November 3, 2015 07:18 Active
@UnspeakableHorror
Added api docs.
8f2be81
@UnspeakableHorror
Changed Notifications to use type to allow adding them into a single
4dc8f38 
list instead of a map of lists. Easier to sort on the frontend and
distinguish between them as well.
Added notifications to test.
Added tables to pgsql script.
Added endpoints to swagger-ui.
@natebenson natebenson deployed to vyllage-pr-1152 November 4, 2015 00:54 Active
@natebenson natebenson deployed to vyllage-pr-1152 November 4, 2015 01:01 Active
@tylerbenson
Copy link
Owner

This PR is a bit large for my taste. In the future try to keep it smaller.

@UnspeakableHorror UnspeakableHorror mentioned this pull request Nov 4, 2015
Merged
@UnspeakableHorror UnspeakableHorror mentioned this pull request Nov 5, 2015
Merged
tylerbenson
tylerbenson reviewed Nov 5, 2015
View reviewed changes
assets/src/components/resume/store.js
data = assign({}, data, {
sectionVersion: 1
})
data = assign({}, data);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelonoel or @tarex can you review the Javascript changes here please?

@natebenson natebenson deployed to vyllage-pr-1152 November 5, 2015 13:33 Active
@natebenson natebenson deployed to vyllage-pr-1152 November 5, 2015 13:39 Active
tylerbenson added a commit that referenced this pull request Nov 5, 2015
@tylerbenson
Merge pull request #1152 from natebenson/carlos/notification-dropdown
7c06f0c 
Notification dropdown
@tylerbenson tylerbenson merged commit 7c06f0c into master Nov 5, 2015
@tylerbenson tylerbenson deleted the carlos/notification-dropdown branch November 5, 2015 17:01
This was referenced Nov 13, 2015
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@UnspeakableHorror UnspeakableHorror

Labels
back end front end ready for review
Projects
None yet
Milestone
2015-11-13
Development

Successfully merging this pull request may close these issues.
3 participants
@UnspeakableHorror @tylerbenson @natebenson