Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow svgs with titles to keep them after svgo optimization #68

Closed
paulrudy opened this issue Nov 15, 2022 · 1 comment · Fixed by #111
Closed

Allow svgs with titles to keep them after svgo optimization #68

paulrudy opened this issue Nov 15, 2022 · 1 comment · Fixed by #111
Labels
enhancement New feature or request
Milestone

Comments

@paulrudy
Copy link

Thanks for this plugin! I have a suggestion:

It looks like svgo's removeTitle plugin is enabled by default.

While I learned from #36 that there is a prop for adding a title to an svg, I think it would be helpful to permit svg's that already have a title embedded to keep their titles, without needing to re-add them.

Perhaps either svgo's removeTitle plugin could be optionally disabled, or perhaps there could be a prop for astro-icon to preserve any already-existing title?

@stramel stramel added the enhancement New feature or request label Mar 15, 2023
@stramel
Copy link
Collaborator

stramel commented Mar 15, 2023

I believe this will be addressed in the v1 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants