Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible integration of my patches? #1

Closed
samrocketman opened this issue Aug 2, 2014 · 3 comments
Closed

Possible integration of my patches? #1

samrocketman opened this issue Aug 2, 2014 · 3 comments

Comments

@samrocketman
Copy link

Hi @naterh,
I've created two pull requests for Herd which I think might interest you. I realize you've made considerable changes to horde but something to consider.

russss#13
russss#14

I tried forking Horde but it GitHub wouldn't allow it. It automatically redirected me to my Herd fork and mentioned it was the same thing. It would have been better for you to push horde as an origin repository and fork Herd. Then you could have added them both as remotes and I could fork Horde and contribute back to it.

@samrocketman
Copy link
Author

Also I encountered a bug.

$ ./horde.py --help
Traceback (most recent call last):
  File "./horde.py", line 13, in <module>
    import BitTornado.BT1.track as bttrack
  File "/home/sam/git/Herd/build/lib/horde/BitTornado/BT1/track.py", line 4, in <module>
    from horde.BitTornado.parseargs import parseargs, formatDefinitions
  File "/home/sam/git/Herd/build/lib/horde/horde.py", line 13, in <module>
    import BitTornado.BT1.track as bttrack
AttributeError: 'module' object has no attribute 'track'

This happens running ./horde.py and when running python setup.py build and then ./horde.py.

@samrocketman
Copy link
Author

Never mind I figured out that installing was a requirement. I have integrated my random port generation patch. I'll follow with instructions for you to pull it.

@samrocketman
Copy link
Author

Since I have given you integrated patches I'm going to just close this. Please pull 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant