Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search ability #40

Open
natetharp opened this issue May 11, 2020 · 1 comment
Open

Add Search ability #40

natetharp opened this issue May 11, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@natetharp
Copy link
Owner

natetharp commented May 11, 2020

Add a search function to the site.

Location:
The search input field can be added to the header.

Specs:

  • The default text for search input should be at least 16px
  • The input type should be search to ensure that it receives the proper iOS keyboard
  • The <input> tag should be nested within a <form> tag to ensure that it receives the proper iOS keyboard
  • Ideally the search function will surface all frontmatter and fulltext of all the profiles, but if that is not possible, frontmatter only would be acceptable

The type of search (live search or query submission) will determine whether it needs a dedicated /search/ page or not.

References:

@natetharp natetharp added the enhancement New feature or request label May 11, 2020
@natetharp
Copy link
Owner Author

With data now coming from Airtable and being saved in a JSON file, there will be no need to access frontmatter for the purposes of search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant