This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Security: Fixed policy injection issue #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON policy file to be signed by the users AWS credentials was being generated as a string and included user controlled data. This could allow an attacker to inject into the JSON and modify the ACL. The JSON hash is now being generated from a Ruby hash in order to prevent injection attacks.
nathancolgate
added a commit
that referenced
this pull request
Feb 17, 2014
Security: Fixed policy injection issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON policy file to be signed by the users AWS credentials was being
generated as a string and included user controlled data. This could
allow an attacker to inject into the JSON and modify the ACL.
The JSON hash is now being generated from a Ruby hash in order to
prevent injection attacks.