Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm installuses non-standard https://registry.npmjs.com invalidating CLI npm login #87

Closed
cdierkens opened this issue May 29, 2020 · 0 comments · Fixed by #88
Closed

Comments

@cdierkens
Copy link
Contributor

Details

Passing in the flag --auth will forward to an Authorization header which works for retrieving the package details.

However, if you are relying on an npm login session for the final spawnInstall, the authentication is only recognized for the default https://registry.npmjs.org registry

The following change overrode the system default with an explicit default.
v1.10.2...v1.11.0#diff-910193ee18e1d63616f5f4408fca259bR284

I'm proposing an update that matches the default registry with what's on https://docs.npmjs.com/using-npm/registry.html

Expected

Default registry passed into installPeerDeps should match NPM's default registry of https://registry.npmjs.org

Actual

Default registry passed into installPeerDeps is non-standard https://registry.npmjs.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant