-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatConfig option to all components #1149
base: next
Are you sure you want to change the base?
Conversation
Hey! I don't get it, could you please elaborate?
The build should be run by the deployment pipeline and I don't need to push
anything else, am I missing something?
…On Tue, Jun 21, 2022 at 11:53 AM Kostiantyn Trots-Aleksandrov < ***@***.***> wrote:
Hey @agualis <https://github.com/agualis>! Just not to duplicate PR's can
you please also build the project (npm run build) so that it would be
fully workable?
—
Reply to this email directly, view it on GitHub
<#1149 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKBLECQCD5OANGQGQGVAIDVQGGIVANCNFSM5XVHRZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sorry my bad. You are completely right, just because the pipeline is not updated yet for vue3, it seems like only author can push new versions |
@nathanreyes Any chance to see this merged? |
@agualis Might need to rework this against the v3.0.3 release since things have changed quite a bit. |
I would also love to see this merged. |
@elizatlawy @hyshka I just solved the conflicts but I had to use |
@agualis The build keeps failing for me with some related and unrelated typing issues. I might not have a proper TS setup. |
I tried I'm not working with compat mode anymore and I don't know how to fix this problem, sorry 😌 |
As explained in this closed issue , Vue3
v-calendar
components are not working when using @vue/compat.This PR adds
compatConfig: { MODE: 3 }
to all components to make them work invue-compat
mode.This option will be simply ignored when the client app is not using
vue-compat
mode.