Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatConfig option to all components #1149

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

agualis
Copy link

@agualis agualis commented Jun 2, 2022

As explained in this closed issue , Vue3 v-calendar components are not working when using @vue/compat.

This PR adds compatConfig: { MODE: 3 } to all components to make them work in vue-compat mode.

This option will be simply ignored when the client app is not using vue-compat mode.

@agualis agualis changed the base branch from next to release/next June 2, 2022 14:54
@agualis agualis changed the base branch from release/next to next June 2, 2022 14:55
@agualis
Copy link
Author

agualis commented Jun 21, 2022 via email

@trotsaleksandrov
Copy link

Hey! I don't get it, could you please elaborate? The build should be run by the deployment pipeline and I don't need to push anything else, am I missing something?

On Tue, Jun 21, 2022 at 11:53 AM Kostiantyn Trots-Aleksandrov < @.> wrote: Hey @agualis https://github.com/agualis! Just not to duplicate PR's can you please also build the project (npm run build) so that it would be fully workable? — Reply to this email directly, view it on GitHub <#1149 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKBLECQCD5OANGQGQGVAIDVQGGIVANCNFSM5XVHRZHA . You are receiving this because you were mentioned.Message ID: @.>

Sorry my bad. You are completely right, just because the pipeline is not updated yet for vue3, it seems like only author can push new versions

@dschmidt
Copy link

@nathanreyes Any chance to see this merged?

@hyshka
Copy link

hyshka commented Apr 3, 2023

@agualis Might need to rework this against the v3.0.3 release since things have changed quite a bit.

@elizatlawy
Copy link

I would also love to see this merged.

@agualis
Copy link
Author

agualis commented May 15, 2023

@elizatlawy @hyshka I just solved the conflicts but I had to use defineOptions({ compatConfig: { MODE: 3 } }); in TimePicker and CalendarNav. I'm not sure if it will work. Please test it in your local repos pointing to this fork 🙏

@hyshka
Copy link

hyshka commented May 15, 2023

@agualis The build keeps failing for me with some related and unrelated typing issues. I might not have a proper TS setup.

image

@agualis
Copy link
Author

agualis commented May 24, 2023

I tried configureCompat but it didn't work neither.

I'm not working with compat mode anymore and I don't know how to fix this problem, sorry 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants